Repository navigation
[Teams Chatbot] Onboard API Stewardship Board #17266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jiaqi Zhang (JiaqiZhang-Dev)
wants to merge
46
commits into
main
Choose a base branch
from
jiaqizhang-dev-api-stewardship-chatbot
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+793
−3
Open
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
1fd1856
Teams Chatbot: onboard API Stewardship Board
JiaqiZhang-Dev 6565d9a
Teams Chatbot: reuse SDK listeners for Stewardship dev and test
JiaqiZhang-Dev 6eb1a30
Teams Chatbot: make Stewardship eval cases customer-facing
JiaqiZhang-Dev fa87d08
Teams Chatbot: clarify Stewardship review workflow and concise answers
JiaqiZhang-Dev 11259b5
Teams Chatbot: scope Stewardship searches and tighten review responses
JiaqiZhang-Dev 1d0debf
Teams Chatbot: shorten Stewardship request identification
JiaqiZhang-Dev 774f9eb
Teams Chatbot: use service type terminology in Stewardship skill
JiaqiZhang-Dev dda8824
Teams Chatbot: refer ARM reviews to ARM Office Hours
JiaqiZhang-Dev 3b1c02d
Teams Chatbot: simplify Stewardship tenant workflow
JiaqiZhang-Dev 31e7400
Teams Chatbot: replace strict word limits with focused answer guidance
JiaqiZhang-Dev 2b6befc
Teams Chatbot: keep Stewardship bullets and citations concise
JiaqiZhang-Dev 9c760b9
Merge origin/main into jiaqizhang-dev-api-stewardship-chatbot
JiaqiZhang-Dev f173f1f
Consolidate Stewardship guidance and GitHub retrieval handling
JiaqiZhang-Dev 6f4f77d
Refine Stewardship skill description and remove brevity instruction
JiaqiZhang-Dev 781a6d4
Use channel routing for Stewardship evaluations
JiaqiZhang-Dev 34aabb7
Keep PR responses focused and support self-service workflow access
JiaqiZhang-Dev d7ea416
Include workflow access request guidance when permissions are unknown
JiaqiZhang-Dev 6a63501
Simplify workflow permission guidance to request access
JiaqiZhang-Dev 55c77a0
Include public organization membership in workflow access guidance
JiaqiZhang-Dev 745f73d
Prioritize PR investigation steps and allow irrelevant steps to be sk…
JiaqiZhang-Dev 1407579
Short-circuit general draft PR reviews in the first step
JiaqiZhang-Dev 2f3ad67
Keep Stewardship skill description focused on its core responsibility
JiaqiZhang-Dev 021c69d
Keep PR answers focused on conclusions rather than status inventories
JiaqiZhang-Dev c97650a
Keep draft PR preflight replies brief and avoid unsupported wait advice
JiaqiZhang-Dev 1694ef5
Keep workflow gate replies actionable without prescribing answer format
JiaqiZhang-Dev 27ba859
Refine self-service access guidance and tenant skill routing
JiaqiZhang-Dev 052d1a3
Scope chat agent instruction changes to PR review
JiaqiZhang-Dev 9a40225
Prioritize resolution and KB guidance for pending PR checks
JiaqiZhang-Dev ff377aa
Condense PR review workflow while preserving safeguards
JiaqiZhang-Dev 9bf171c
Use PR status and labels for flexible review triage
JiaqiZhang-Dev e7fdd0d
Improve PR failure diagnosis and Stewardship evaluations
JiaqiZhang-Dev 31bae46
Prioritize evidence applicability in chat answers
JiaqiZhang-Dev 185f708
Scope Stewardship evaluation references to customer questions
JiaqiZhang-Dev 642c326
Merge origin/main into jiaqizhang-dev-api-stewardship-chatbot
JiaqiZhang-Dev 28cb4de
Fix optional log iteration in GitHub MCP parser
JiaqiZhang-Dev f80eaae
Revert README changes from Stewardship onboarding PR
JiaqiZhang-Dev 80b7977
Organize Stewardship guidance as a request workflow
JiaqiZhang-Dev 2ff4b51
Include Actions check runs in PR review preflight
JiaqiZhang-Dev c0a2ae8
Share Azure SDK Logic App listeners in dev and test
JiaqiZhang-Dev a564eaa
Preserve expert answers in Stewardship evaluations
JiaqiZhang-Dev 6dee091
Document upstream GitHub job-log tool naming
JiaqiZhang-Dev 022edd8
Remove Stewardship engineering-doc title restriction
JiaqiZhang-Dev aac2cab
Remove API Spec Review engineering-doc title restriction
JiaqiZhang-Dev 9317568
Chatbot: extract shared diagnostics and listener fixes
JiaqiZhang-Dev 1fb7365
Merge shared chatbot fixes as Stewardship prerequisite
JiaqiZhang-Dev d69ee38
Merge main into API Stewardship chatbot onboarding
JiaqiZhang-Dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletions
50
...bots/azure-sdk-qa-bot-agent/pipelines/logicapp/parameters.api_stewardship_board.prod.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| { | ||
| "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentParameters.json#", | ||
| "contentVersion": "1.0.0.0", | ||
| "parameters": { | ||
| "logicAppName": { | ||
| "value": "api-stewardship-board-qabot-logicapp" | ||
| }, | ||
| "workflowState": { | ||
| "value": "Disabled" | ||
| }, | ||
| "teamsGroupId": { | ||
| "value": "1a10b50c-e870-4fe0-8483-bf5542a8d2d8" | ||
| }, | ||
| "teamsChannelIds": { | ||
| "value": [ | ||
| "19:3ebb18fded0e47938f998e196a52952f@thread.tacv2" | ||
| ] | ||
| }, | ||
| "serverBaseUrl": { | ||
| "value": "https://azuresdkqabot-server-c8czabhzhweadwgu.westus2-01.azurewebsites.net" | ||
| }, | ||
| "serverAudience": { | ||
| "value": "899da762-d510-48f2-911a-db9ea0cc41fd" | ||
| }, | ||
| "serverIdentityResourceId": { | ||
| "value": "/subscriptions/a18897a6-7e44-457d-9260-f2854c0aca42/resourceGroups/azure-sdk-qa-bot/providers/Microsoft.ManagedIdentity/userAssignedIdentities/azuresdkqabot-identity" | ||
| }, | ||
| "botBaseUrl": { | ||
| "value": "https://azsdkqabot.azurewebsites.net" | ||
| }, | ||
| "botAudience": { | ||
| "value": "ff836b38-c7d8-459a-a504-57b60b50b4eb" | ||
| }, | ||
| "botIdentityResourceId": { | ||
| "value": "/subscriptions/a18897a6-7e44-457d-9260-f2854c0aca42/resourceGroups/azure-sdk-qa-bot/providers/Microsoft.ManagedIdentity/userAssignedIdentities/azsdkqabot" | ||
| }, | ||
| "teamsConnectionResourceId": { | ||
| "value": "/subscriptions/a18897a6-7e44-457d-9260-f2854c0aca42/resourceGroups/azure-sdk-qa-bot/providers/Microsoft.Web/connections/teams" | ||
| }, | ||
| "integrationAccountResourceId": { | ||
| "value": "/subscriptions/a18897a6-7e44-457d-9260-f2854c0aca42/resourceGroups/azure-sdk-qa-bot/providers/Microsoft.Logic/integrationAccounts/azuresdkqabot-ia" | ||
| }, | ||
| "userAssignedIdentities": { | ||
| "value": { | ||
| "/subscriptions/a18897a6-7e44-457d-9260-f2854c0aca42/resourceGroups/azure-sdk-qa-bot/providers/Microsoft.ManagedIdentity/userAssignedIdentities/azsdkqabot": {}, | ||
| "/subscriptions/a18897a6-7e44-457d-9260-f2854c0aca42/resourceGroups/azure-sdk-qa-bot/providers/Microsoft.ManagedIdentity/userAssignedIdentities/azuresdkqabot-identity": {} | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
tools/sdk-ai-bots/azure-sdk-qa-bot-agent/prompts/tenants/api_stewardship_board.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| <!-- Copyright (c) Microsoft Corporation. --> | ||
| <!-- Licensed under the MIT License. --> | ||
|
|
||
| # Tenant: API Stewardship Board Assistant | ||
|
|
||
| ## Scope | ||
|
|
||
| Help with data-plane API design and Board reviews. Give evidence-backed advice, not Board decisions. Do not repair infrastructure or prescribe resource-specific permission changes. | ||
|
|
||
| Direct ARM/management-plane reviews to [ARM Office Hours](https://armwiki.azurewebsites.net/introduction/office_hours.html) and stop this Board review workflow. | ||
|
|
||
| ## 1. Understand the request | ||
|
|
||
| Use the latest confirmed thread resolution; distinguish proposals from decisions and preserve withdrawals. | ||
|
|
||
| ## 2. Gather evidence | ||
|
|
||
| Load `pr-review` for check diagnosis, feedback and merge readiness. Treat bot summaries as starting evidence; verify blockers against live current-head state. | ||
|
|
||
| Retrieve maintained guidance for the unresolved question identified from the PR or request. Pass known `service_type="data-plane"` or `service_type="management-plane"` to `search_knowledge_base`, including the initial search; leave it unset when ambiguous or general. Use PR labels, paths or explicit wording, never the channel. `wiki_search` has no service-type filter. | ||
|
|
||
| ## 3. Apply the relevant policy | ||
|
|
||
| As applicable: | ||
|
|
||
| - Keep REST signoff, breaking-change exceptions, SDK/API review and package-name approval separate. Verify live `.github/protected-labels.yml` for approval authority; approval does not transfer to another PR. | ||
| - Distinguish published-version edits from new versions, preview from GA, and REST from SDK compatibility. Verify the applicable baseline and policy; do not invent requirements for inaccessible material. | ||
| - Separate SDK/documentation visibility from service authorization. Verify preview classification from policy and availability, not AFEC alone. | ||
| - For retirement, verify affected versions, applicable notice requirements and approval evidence; do not generalize prior approvals. | ||
|
|
||
| ## 4. Recommend the next action | ||
|
|
||
| Help the author take the next useful action from current evidence, rather than restart completed review work. Answer concisely; omit review checklists and repeated conclusions or links. | ||
|
|
||
| Use maintained Board guidance for async reviews, materials, lead times, Office Hours and support. Do not send users back to this channel to repeat their question. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.