Repository navigation
Protect partially completed release plans from abandonment - #17223
Merged
Helen Gao (helen229) merged 7 commits intoOct 27, 2026
Merged
Conversation
github-actions
Bot
added
the
azsdk-cli
|
Azure Pipelines: Successfully started running 3 pipeline(s). 69 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No blocking issues remain in the supplied review evidence, with targeted tests covering safeguards and contract changes; tests were not rerun.
No open issues 🎉
What changed in this PR
Adds manual-abandonment safeguards to the Azure SDK release-plan workflow, addressing #17126 while preserving separate cleanup policies.
Changes:
- Blocks abandonment after SDK releases or merged PRs, with revision-guarded writes.
- Requires Release Plan ID across CLI, MCP, mocks, and agent guidance.
- Adds safeguard and contract tests, updates documentation, and corrects guide links.
| File | Description |
|---|---|
| tools/azsdk-cli/README.md | Documents safeguards and corrects links. |
| tools/azsdk-cli/docs/mcp-tools.md | Updates abandonment tool documentation. |
| tools/azsdk-cli/Azure.Sdk.Tools.Mock/Tests/ReleasePlanSpecCommitHandlerTests.cs | Tests mock validation and schema parity. |
| tools/azsdk-cli/Azure.Sdk.Tools.Mock/Handlers/ReleasePlan/ReleasePlanRemainingHandlers.cs | Validates Release Plan ID arguments. |
| tools/azsdk-cli/Azure.Sdk.Tools.Cli/Tools/ReleasePlan/ReleasePlanTool.cs | Implements eligibility checks and guarded abandonment. |
| tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/DevOpsService.cs | Adds optional lookup of abandoned plans. |
| tools/azsdk-cli/Azure.Sdk.Tools.Cli/CHANGELOG.md | Records safeguards and breaking input changes. |
| tools/azsdk-cli/Azure.Sdk.Tools.Cli.Tests/Tools/ReleasePlan/ReleasePlanToolTests.cs | Updates command-contract tests. |
| tools/azsdk-cli/Azure.Sdk.Tools.Cli.Tests/Tools/ReleasePlan/ReleasePlanAbandonmentTests.cs | Covers safeguards, failures, and cancellation. |
| tools/azsdk-cli/Azure.Sdk.Tools.Cli.Tests/TestData/TestPrompts.json | Uses Release Plan ID in prompts. |
| tools/azsdk-cli/Azure.Sdk.Tools.Cli.Tests/Services/DevOpsServiceTests.cs | Tests lookup filtering and revision conflicts. |
| tools/azsdk-cli/Azure.Sdk.Tools.Cli.Tests/Mocks/Services/MockDevOpsService.cs | Supports the new lookup overload. |
| plugins/azure-sdk-tools/skills/prepare-release-plan/SKILL.md | Updates plugin argument guidance. |
| evals/tools/prompt-to-tool-releaseplan.eval.yaml | Aligns evaluation prompts with the new contract. |
| .github/skills/azsdk-common-prepare-release-plan/SKILL.md | Updates source skill argument guidance. |
Review effort: Balanced
Praveen Kuttappan (praveenkuttappan)
approved these changes
Oct 27, 2026
Sameeksha Vaity (samvaity)
approved these changes
Oct 27, 2026
Member
Author
|
/check-enforcer override |
Helen Gao (helen229)
deleted the
fix/17126-protect-partial-release-abandonment
branch
October 27, 2026 20:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protect release plans from abandonment after any SDK PR has merged or any SDK is recorded as Released.
Related: #17126. Review this guard before the stacked cleanup PR #17224.
Behavior
azsdk release-plan abandon --release-plan-id <id>/ MCPreleasePlanId. ItsworkItemIdinput is removed; other commands retain their existing contracts.Latest reviewer follow-up
includeAbandoned = false; preserve existing callers' filtering and cancellation behavior.Validation
Ready for re-review; new hosted checks must finish before merge. No live plan abandonment, SDK PR cleanup, model eval, deployment, or release was performed. No admin authorization, monthly cleanup, permissions, force/approval inputs, or automatic-write retries were added. GitHub reads and the ADO write are not a cross-service transaction.