Skip to content

Support pnpm TypeSpec metadata discovery - #17190

Draft
Evan Waldmann (waldmannly) wants to merge 1 commit into
Azure:mainfrom
waldmannly:fix/typespec-pnpm-metadata
Draft

Evan Waldmann (waldmannly) wants to merge 1 commit into
Azure:mainfrom
waldmannly:fix/typespec-pnpm-metadata

Conversation

@waldmannly

Copy link
Copy Markdown
Member

Summary

  • detect pnpm-lock.yaml when preparing TypeSpec metadata discovery
  • use the repository's declared packageManager via corepack pnpm install --frozen-lockfile
  • retain the existing package-lock.json / npm ci path
  • surface dependency-install, metadata-emitter, and missing-output failures instead of treating them as successful empty package discovery
  • preserve the informational empty-package result when the emitter succeeds and genuinely emits no package metadata

Motivation

The release plan 36758 SDK-details update reported No package details were identified even though metadata discovery had not completed successfully. azure-rest-api-specs moved from npm to pnpm in Azure/azure-rest-api-specs#43922, while TypeSpecHelper only recognized package-lock.json and ran npm ci. Emitter failures and missing metadata output could then return an empty TypeSpecProject, making the release-plan update look successful.

Validation

dotnet test tools\azsdk-cli\Azure.Sdk.Tools.Cli.Tests\Azure.Sdk.Tools.Cli.Tests.csproj \
  --filter "FullyQualifiedName~TypeSpecHelperTests|FullyQualifiedName~ReleasePlanToolTests.Test_Update_SDK_Details" \
  --no-restore --verbosity minimal -p:CopilotSkipCliDownload=true

57 tests passed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 92b19150-680b-4812-ae55-c16cdd60ac81
@github-actions github-actions Bot added the azsdk-cli Issues related to Azure/azure-sdk-tools::tools/azsdk-cli label Oct 5, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
68 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azsdk-cli Issues related to Azure/azure-sdk-tools::tools/azsdk-cli

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant