Repository navigation
Sync eng/common directory with azure-sdk-tools for PR 17350 - #27818
Merged
Helen Gao (helen229) merged 5 commits intoOct 22, 2026
Merged
Conversation
Co-authored-by: helen229 <19517014+helen229@users.noreply.github.com>
azure-sdk-automation
Bot
added
EngSys
|
Azure Pipelines: Successfully started running 1 pipeline(s). 6 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The Node.js major-version change and Vally/Copilot SDK upgrades need end-to-end pipeline validation and final human review.
No open issues 🎉
What changed in this PR
Syncs shared evaluation tooling from azure-sdk-tools PR 17350 into Azure SDK for Go, following the eng/common workflow.
Changes:
- Upgrades Vally CLI from
0.14.0to0.19.0and refreshes transitive dependencies. - Raises the evaluator’s Node.js minimum to
24.14.1and switches matrix generation to Node.js24.x. - Expands tests checking shared Copilot authentication templates and permissions.
| File | Description |
|---|---|
eng/common/scripts/eval/README.md |
Documents aligned Node.js requirements. |
eng/common/scripts/eval/publisher/test/publisher.test.ts |
Adds authentication-template assertions. |
eng/common/scripts/eval/package.json |
Updates Node.js minimum and Vally CLI pin. |
eng/common/scripts/eval/package-lock.json |
Locks the upgraded dependency tree. |
eng/common/pipelines/templates/jobs/generate-eval-matrix.yml |
Uses Node.js 24.x for matrix generation. |
Review effort: Balanced
Helen Gao (helen229)
approved these changes
Oct 22, 2026
Helen Gao (helen229)
left a comment
Helen Gao (helen229)
left a comment
Member
There was a problem hiding this comment.
Approving the eng/common sync from Azure/azure-sdk-tools#17350. All five file patches and resulting contents match the source, including the locked Vally 0.19.0 upgrade and Node requirement.
Helen Gao (helen229)
deleted the
sync-eng-common-fix/eval-mcp-app-runtime-17350
branch
October 22, 2026 19:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#17350 See eng/common workflow