Skip to content

[ContainerService] Scope legacy naming suppressions for ARM review - #47548

Draft
FumingZhang wants to merge 1 commit into
dev-containerservice-Microsoft.ContainerService-2026-09from
fuming/aks-2026-09-scoped-suppression-review
Draft

FumingZhang wants to merge 1 commit into
dev-containerservice-Microsoft.ContainerService-2026-09from
fuming/aks-2026-09-scoped-suppression-review

Conversation

@FumingZhang

Copy link
Copy Markdown
Member

Purpose

Targets dev-containerservice-Microsoft.ContainerService-2026-09, not main.
Review comment: #47398 (comment)

Changes

  • Replace the blanket DefinitionsPropertiesNamesCamelCase suppression with exact JSONPath exceptions for enableRBAC and 23 published acronym spellings.
  • Include Markdown in the existing AKS-local spelling dictionary override so the explicit legacy field names pass SpellCheck.
  • No TypeSpec model, generated Swagger, wire format, SDK method or backend implementation changes.

The two-file delta is preserved byte-for-byte from the reviewed suppression proposal in commit ffe0dfd3d47bfd5efcab6cec79d7dc8fa68dbbe7; it was not discarded to hide a failure. The parent fixes PR now retains the dev branch's existing suppression policy unchanged.

Validation

  • git diff --check passed.
  • Exact comparison confirms this is the same two-file proposal previously validated by the repository's actual PowerShell SpellCheck script.
  • A scan using the pinned validator's camelCase rule across all 121 existing managedClusters contracts confirms that every existing nonconforming acronym path is enumerated.
  • Earlier same-validator September before/after checks showed no new diagnostics after scoping these exceptions.

Required human review

This PR deliberately remains draft and requires legitimate Approved-Suppression approval.
The reviewer must confirm the compatibility reasons and exact scope before granting the label. No approval is fabricated or applied by the authoring agent.

Separating this policy decision lets #47509 be tested independently without blocking its code fixes on a manual approval. It does not bypass, remove, or modify any CI check.

Separate ARM finding 6 from the executable spec fixes: retain published acronym spellings with exact JSONPath exceptions instead of a blanket naming suppression. This policy change remains draft pending legitimate suppression approval.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ The suppressions added to the AutoRest config files (README.mds) require review. Refer to step 1 in the PR workflow diagram, or to step 3, depending on the kind of suppression you did.


Comment generated by summarize-checks workflow run.

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
JavaScript @azure/arm-containerservice
Python azure-mgmt-containerservice

Comment generated by After APIView workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant