Skip to content

Revert "Add repository-owned TypeSpec linter rulesets" - #47312

Merged
catalinaperalta merged 1 commit into
mainfrom
catalinaperalta/revert-specs-repo-linter-rulesets
Oct 15, 2026
Merged

catalinaperalta merged 1 commit into
mainfrom
catalinaperalta/revert-specs-repo-linter-rulesets

Conversation

@catalinaperalta

Copy link
Copy Markdown
Member

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

Purpose

Draft rollback of #46750, requested for review before any merge.

Applied git revert --no-commit 4511245ac385c8ffdb11e3174f126a1c8f48bb30 on current main, without conflicts. This restores the upstream TypeSpec linter ruleset references, removes the private repository-owned ruleset package, and reverts the associated validator, tests, workspace configuration, workflow, and guidance changes.

No .tsp source or API definitions are changed. The separate package-name YAML parser fix from #47304 is preserved.

Validation

Checks are continuing after opening this draft, as requested.

  • pnpm install --frozen-lockfile - passed.
  • pnpm --filter @azure-tools/specs-shared check - passed, including 100% coverage, lint, TypeScript, and formatting.
  • pnpm --filter @azure-tools/typespec-validation check - in progress.
  • pnpm --filter azure-rest-api-specs-github check - failed on the same three previously observed unrelated tests: a Windows symlink-permission failure in label-catalog-loader.test.ts and two resource-provider assertions in arm-lease-fetch-resource-providers.test.ts. Results: 1170 passed, 3 failed, 12 skipped.
  • pnpm --filter azure-rest-api-specs-github lint and pnpm --filter azure-rest-api-specs-github format:check - in progress independently because the aggregate command stops at test failures.
  • git diff --cached --check - reports a blank line at EOF in .github/prompts/tspconfig_add_missing_languages.prompt.md, restored by the exact revert. Left unchanged to preserve the rollback.

Opened as a draft before the remaining checks finish, per user instruction.

This reverts commit 4511245.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 2c14a849-7b23-4efc-bf0f-4e287ef79986
@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is awaiting ARM reviewer feedback (label: WaitForARMFeedback).
    To learn when this PR will get reviewed, see ARM review queue at aka.ms/azsdk/pr-arm-review
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named Swagger Avocado has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants