Repository navigation
e2e: allow serial DPS registrations to complete - #1261
Merged
Carter Tinney (cartertinney) merged 3 commits intoSep 2, 2026
Merged
Conversation
Raise the DPS suite timeout above the SDK registration timeout so operation errors can surface, and give certificate group tests a larger backstop for their three sequential registrations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Calculate each serial group-registration timeout as 40 seconds per configured device so expanding or shrinking a group automatically updates its test backstop. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Carter Tinney (cartertinney)
September 2, 2026 21:02
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The timeout changes consistently cover all intended cases and match the stated validation.
Pull request overview
Raises DPS E2E timeouts to accommodate serial X.509 registrations while retaining hang detection.
Changes:
- Increases the suite timeout from 30 to 60 seconds.
- Applies calculated 120-second timeouts to all sync/async X.509 group cases.
File summaries
| File | Description |
|---|---|
test_sync_certificate_enrollments.py |
Adds group timeout calculation and markers. |
test_async_certificate_enrollments.py |
Adds equivalent async timeout handling. |
pytest.ini |
Raises the default suite timeout. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
olivakar
approved these changes
Sep 2, 2026
Carter Tinney (cartertinney)
deleted the
agents/dps-group-registration-timeout
branch
September 2, 2026 22:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
DPS E2E build 163238 timed out in the async X.509 group enrollment MQTT-over-WebSockets case. The suite-level 30-second pytest timeout covered the entire test even though it performs three sequential network registrations.
The same outer timeout also matched the SDK registration stage's 30-second timeout, allowing pytest to interrupt single-registration tests before the SDK could surface its more useful operation error.
A 60-second default preserves bounded hang detection while allowing SDK errors to surface. The 120-second marker is limited to group tests that make three serial registration attempts.
Validation