Repository navigation
feat: add Essentials SKU create support - #950
Ketki Naik (ketkimnaik) wants to merge 15 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Azure SRE Agent - automated reviewReviewing Scope: read all 10 changed files plus the surrounding code they depend on — Blocking
Suggestions
Nits
Checked and clean (recording the negatives so they are not re-derived):
Summary: the code itself is small, well-factored and covered at unit level; the one blocking issue is a sequencing problem — the CI scenario and int assertions added here depend on a SKU-capable deployment template that only arrives in #951. This is an automated review and may be incomplete; please verify findings before acting on them. |
Keep omitted SKU absent even when regenerated templates contain their own SKU expression, and forward SKU when the template exposes a matching parameter. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Azure SRE Agent - automated reviewReviewing Increment is one commit — Blocking None new in this increment. Finding 1 from the previous review still stands unchanged: Suggestions
Nits None. Checked and clean (recording the negatives so the next run does not re-derive them):
Summary: a small, defensive forward-compat commit that is currently a no-op; no new blockers. The substantive ask is to settle whether SKU flows through the template parameter or through the literal injection before the regenerated template lands, and to add a test that exercises the parameter-bearing blueprint. This is an automated review and may be incomplete; please verify findings before acting on them. |
Strip trailing hyphens after limiting ADR namespace names so longer scenarios such as Essentials remain valid. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Azure SRE Agent - automated reviewReviewing Increment is one commit — Blocking None. Suggestions
Nits
Duplicate commit across two open PRs
Checked and clean
Still open from the earlier reviews of this PR, unchanged at this head
This is an automated review and may be incomplete. |
Azure SRE Agent - automated reviewReviewing Increment is one commit — Blocking None. Suggestions None for this increment. One item carried from the earlier reviews is still open at this head and is restated only so it is not lost — not a new finding:
Nits None. Checked and clean
Summary: a two-line documentation improvement to an existing warning, with the assertion added alongside it. Verified externally against the licensing page; nothing to change. This is an automated review and may be incomplete. |
Azure SRE Agent - automated reviewReviewing Increment is one commit — Suggestions
Nits
Carried from the
Checked and clean
Automated review — may be incomplete; please treat findings as input, not as a gate. |
… 4.38.2 (Azure#963) chore(actions-deps): bump github/codeql-action/analyze Bumps [github/codeql-action/analyze](https://github.com/github/codeql-action) from 4.38.1 to 4.38.2. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@1c5b675...2892aa5) --- updated-dependencies: - dependency-name: github/codeql-action/analyze dependency-version: 4.38.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Hangyi <hangyiwang@microsoft.com>
…38.2 (Azure#962) chore(actions-deps): bump github/codeql-action/init Bumps [github/codeql-action/init](https://github.com/github/codeql-action) from 4.38.1 to 4.38.2. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@1c5b675...2892aa5) --- updated-dependencies: - dependency-name: github/codeql-action/init dependency-version: 4.38.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Hangyi <hangyiwang@microsoft.com>
* Add GA preview runtime support * Fix preview runtime compatibility handling * Use structured runtime readiness issues * Use supported preview management API * Preserve diagnostic instance show access * Fix runtime writes and help * Refresh preview runtime and tests * Refresh preview runtime to 22 * Address runtime profile review and support bundle fixes Use tags-only PATCH without runtime discovery, separate Edge Registry support collection, and restore terminal-state recovery and stable force behavior. Identity PATCH changes remain pending RP confirmation. * Add required header to Edge Registry collector * Fix instance API and initialization * Temporarily restore July API default * Refresh GA and preview runtimes and simplify preview opt-in * Fix preview CI, GA force upgrades, and broker checks * Fix preview listener API * Restore forced integration upgrades * Fix unbundled integration upgrade paths * Simplify preview upgrade error wording * Reuse installed runtime for upgrade reconciliation * Remove obsolete create confirmation ignore --------- Co-authored-by: Ketki <ketkinaik@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Azure SRE Agent - automated reviewReviewing The increment is a single merge commit — What I did review is the part a merge can actually break: the conflict resolutions. Replaying the merge ( Blocking None found. Suggestions
Nits
Checked and clean (recording the negatives so they are not re-derived)
Summary: the merge resolution is sound and nothing from either side was lost; the only substantive point is the create-time-only SKU enforcement in suggestion 1. This is an automated review and may be incomplete. |
….1 to 4.38.2 (Azure#961) chore(actions-deps): bump github/codeql-action/upload-sarif Bumps [github/codeql-action/upload-sarif](https://github.com/github/codeql-action) from 4.38.1 to 4.38.2. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@1c5b675...2892aa5) --- updated-dependencies: - dependency-name: github/codeql-action/upload-sarif dependency-version: 4.38.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Hangyi <hangyiwang@microsoft.com>
Summary
--sku {Essentials,Standard}Test target
This PR targets
test/aio-essentials-sku-previewfor qualification only. Preview API/template changes are intentionally not included here and should be made on the test branch after merge, preserving the feature branch for the eventual PR todev.The generated deployment template was not edited manually.
Validation
Live Essentials deployment validation remains pending a SKU-capable backend and synchronized deployment template.