feat(adr): add policy revoke-issuer & device CRUD/revoke commands with restructured tests by HangyiWang · Pull Request #782 · Azure/azure-iot-cli-extension

Hangyi (HangyiWang) · 2026-02-22T05:15:26Z

New Commands

az iot adr ns policy revoke-issuer

Revokes the current CA (issuer) certificate on a credential policy and triggers ICA rotation. After revocation, a new CA certificate is generated automatically. All device credentials issued by the old CA must be re-issued.

For BYOR policies, revocation transitions the policy back to PendingActivation with a new CSR that must be re-signed and re-activated via activate-byor.

az iot adr ns device list

Lists all devices in an ADR namespace.

az iot adr ns device show

Shows details of a specific device.

az iot adr ns device update

Updates device properties including enabled state, policy association, OS version, and attributes.

az iot adr ns device revoke

Revokes all active credentials for a device, forcing re-authentication.

Integration Test Restructuring

Refactored ADR integration tests from 3 monolithic files into 5 focused modules with shared helpers:

File	Tests	Covers
`test_adr_crud_int.py`	1	Namespace create/show/list/update/delete, credential CRUD, policy create/show/list/update/delete
`test_adr_infra_int.py`	1	Full pipeline smoke: UAMI → namespace → Hub Gen2 → DPS → enrollment → credential sync → hub cert verification
`test_adr_device_int.py`	1	Device provisioning via DPS+CSR, device list/show/update (enable/disable), 6 revoke scenarios
`test_adr_byor_int.py`	8	BYOR create, activate, sync-to-hub, revoke+reactivate rotation, edge cases (standard policy guard, mismatched chain, pre-activation revoke)
`test_adr_policy_revoke_int.py`	3	Standard policy revoke-issuer E2E with ICA rotation, single-policy-per-credential limit, nonexistent policy revoke

* Eventhub sdk add * monitoring changes * event changes * add discovery logic * remove unused code * test changes * Add fixes for integration tests * remove readme file * Remove uamqp usage in the code entirely * Replace uampq from docs to pyamqp * Fix failing unit tests * Fix args compatibility issue * Fix linting errors * Addressing comments * Fix linting issues * Addressed comments * Add right exception * remove unwanted exception --------- Co-authored-by: Ketki <ketkinaik@microsoft.com>

* fix: move base64 validation inside validate block for passthrough cases When parsing connection strings with redacted SharedAccessKey=*** values (e.g., from IoT Hub properties), the base64 validation would fail since the redacted value is not valid base64. Move the validation inside the 'if validate:' block so it only runs when full validation is requested. Passthrough cases that only need to extract other properties (like EntityPath, Endpoint) will no longer fail. * fix: skip base64 validation for redacted SharedAccessKey (****) values * Remove defensive check --------- Co-authored-by: Ketki <ketkinaik@microsoft.com>

* Create release data * Improve formatting and remove internal changes --------- Co-authored-by: Ketki <ketkinaik@microsoft.com>

* fix: win/MSI pipeline fixes * fix conditional compile-time/runtime logic issue * fix windows extension path * test: try to repro windows install issue by reordering pipeline stages * fixup * revert pipeline testing changes for now * revert separation of python setup and dev requirements for now

Co-authored-by: Ketki <ketkinaik@microsoft.com>

* Try requirements options * Add range --------- Co-authored-by: Ketki <ketkinaik@microsoft.com>

Co-authored-by: Ketki <ketkinaik@microsoft.com>

…ang/device-revoke

Hangyi (HangyiWang) · 2026-02-23T23:51:26Z

Copilot could you review the PR and list the advice/actions/TODOs one by one

Copilot · 2026-02-23T23:51:34Z

Hangyi (@HangyiWang) I've opened a new pull request, #783, to work on those changes. Once the pull request is ready, I'll request review from you.

* Remove all uampq occurences * Addressed comments and fixed linting errors --------- Co-authored-by: Ketki <ketkinaik@microsoft.com>

Paymaun (digimaun) · 2026-03-03T17:35:01Z

@@ -0,0 +1,46 @@
+# coding=utf-8


Are there async operations being used anywhere? If not why include anything from aio?

Nope - let me remove all aio folder, we only consume operations

Paymaun (digimaun) · 2026-03-05T00:10:38Z

            )
-            return wait_for_terminal_state(poller, **kwargs)
+            result = wait_for_terminal_state(poller, **kwargs)
+            return result.serialize(keep_readonly=True) if result else result


What is the reason for this?

This was changed a while ago, I don’t recall the exact reason, but I believe I needed to serialize it at the time to get some tests passing. If there are any objections, we can revert it.

Paymaun (digimaun) · 2026-03-05T00:12:57Z

+            try:
+                result = wait_for_terminal_state(poller, **kwargs)
+            except HttpResponseError as e:
+                # The backend returns 200 OK with an empty body when the LRO completes,


Has this been raised with the service team?

Not yet - this is a workaround for a while also, let me see if I can reproduce it and file a bug to them.

Paymaun (digimaun) · 2026-03-05T00:13:57Z

        try:
-            return self.client.credentials.get(resource_group_name=resource_group_name, namespace_name=namespace_name)
+            result = self.client.credentials.get(resource_group_name=resource_group_name, namespace_name=namespace_name)
+            return result.serialize(keep_readonly=True)


Another usage of result.serialize I'd like to grok

yeah I can't recall exact reasons

Paymaun (digimaun) · 2026-03-05T00:30:00Z

+        if attributes is not None:
+            properties["attributes"] = attributes
+        if policy_resource_id is not None:
+            properties["policy"] = {"resource_id": policy_resource_id}


How many of the above properties can be deleted or empty? For example, tags. For those that can, we should ensure update can support that.

sotags attributes os_version can be deleted, not sure about policy_resource_id

Paymaun (digimaun) · 2026-03-05T00:36:19Z

@@ -0,0 +1,8243 @@
+# coding=utf-8


Why are we using models in our own clients ?

Because generated SDK methods require them as typed request bodies? Not necessary but it's more convenient pattern in other places.

Paymaun (digimaun) · 2026-03-05T00:44:29Z

@@ -0,0 +1,30 @@
+# coding=utf-8


Don't include this

Ryan K (c-ryan-k) and others added 30 commits October 21, 2025 16:12

fix: draft github release from non-default branches (#758)

a3364f6

fix: solve SDL task warnings

4940fa7

chore(ci): update runner images (#764)

61fbfeb

chore(release): prepare v0.28.0 (#770)

e8aa5e3

* Create release data * Improve formatting and remove internal changes --------- Co-authored-by: Ketki <ketkinaik@microsoft.com>

Follow up changes (#772)

54335ff

Co-authored-by: Ketki <ketkinaik@microsoft.com>

bump azure-iot-device for Windows (#773)

2c59a4b

Co-authored-by: Ketki <ketkinaik@microsoft.com>

Release preparation (#774)

62b2fac

Co-authored-by: Ketki <ketkinaik@microsoft.com>

Update SBOM tool version (#775)

17aede3

Co-authored-by: Ketki <ketkinaik@microsoft.com>

init

6715cff

init

1085d76

inti

1cebe35

ci: fix SBOM generation for pip 25.x compatibility (#776)

501ac72

* Try requirements options * Add range --------- Co-authored-by: Ketki <ketkinaik@microsoft.com>

device show list update

e4ef3ef

flake

644b710

SBOM: use clean venv for runtime deps (#780)

017a4c8

Co-authored-by: Ketki <ketkinaik@microsoft.com>

test

3afdc79

Merge branch 'users/hangyiwang/update-new-adr-sdk' into users/hangyiw…

7563ad7

…ang/device-revoke

mrege

22647cb

int

9d33aea

unittest

66da565

merge

db97134

Merge branch 'users/hangyiwang/update-new-adr-sdk' into users/hangyiw…

a2a09d9

…ang/device-revoke

canary test

7feaead

test

6a3c594

merge

a494a8c

refactor

1878fc3

lint

2b55ccb

lint

1c811f5

Copilot AI mentioned this pull request Feb 23, 2026

feat(adr): add policy revoke-issuer & device CRUD/revoke commands with restructured tests #783

Closed

Ketki Naik (ketkimnaik) and others added 4 commits February 24, 2026 13:25

chore: remove uamqp references from codebase (#784)

8ca1dd8

* Remove all uampq occurences * Addressed comments and fixed linting errors --------- Co-authored-by: Ketki <ketkinaik@microsoft.com>

test

87d5da1

fix

bcd0664

log

3eb5d8b

Hangyi (HangyiWang) marked this pull request as ready for review March 3, 2026 02:58

Hangyi (HangyiWang) requested a review from Paymaun (digimaun) as a code owner March 3, 2026 02:58

Hangyi (HangyiWang) added 2 commits March 3, 2026 03:12

flake

e941db0

version

e53ccad

Paymaun (digimaun) reviewed Mar 3, 2026

View reviewed changes

Paymaun (digimaun) reviewed Mar 5, 2026

View reviewed changes

Comment thread docs/sdk-generation-guide.md

Hangyi (HangyiWang) added 3 commits March 6, 2026 18:14

comments

c31afaf

dev

1593a65

sdk

6d2348a

Hangyi (HangyiWang) closed this Mar 6, 2026

Conversation

Hangyi (HangyiWang) commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New Commands

Integration Test Restructuring

Uh oh!

Hangyi (HangyiWang) commented Feb 23, 2026

Uh oh!

Copilot AI commented Feb 23, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Hangyi (HangyiWang) commented Feb 22, 2026 •

edited

Loading