Skip to content

Distill Agent Go skills and instructions#4354

Open
rbtr wants to merge 4 commits intomasterfrom
rbtr-skills
Open

Distill Agent Go skills and instructions#4354
rbtr wants to merge 4 commits intomasterfrom
rbtr-skills

Conversation

@rbtr
Copy link
Copy Markdown
Collaborator

@rbtr rbtr commented Apr 14, 2026

Reason for Change:
Distills years of repo code changes, review feedback, and comments in to guiding Agent skills focused on Go code quality and forward-looking maintainability.

Issue Fixed:

Requirements:

Notes:

Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
@rbtr rbtr requested a review from a team as a code owner April 14, 2026 21:58
Copilot AI review requested due to automatic review settings April 14, 2026 21:58
@rbtr rbtr requested review from a team as code owners April 14, 2026 21:58
@rbtr rbtr requested a review from ramiro-gamarra April 14, 2026 21:58
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds repository-wide and CNS-specific agent guidance plus a set of Go-focused “skills” documents intended to drive consistent code quality and maintainability for contributors/AI coding agents.

Changes:

  • Introduces root + CNS-scoped agents.md instruction docs and wires them into Copilot/Claude instruction entrypoints.
  • Adds multiple .github/skills/acn-go-* skill documents covering Go API contracts, design boundaries, context lifecycle, platform abstraction, errors/logging, interfaces/dependencies, and types/parsing.
  • Documents CNS architecture context and recommended repo skills/tests for CNS work.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
cns/agents.md Adds CNS-specific architecture/flow notes and prescriptive skill mapping for code areas.
agents.md Adds general agent behavioral guidelines to reduce common implementation mistakes.
CLAUDE.md Establishes a single instruction entrypoint for Claude-based agents.
.github/copilot-instructions.md Establishes a single instruction entrypoint for GitHub Copilot.
.github/skills/acn-go-types-parsing/SKILL.md Adds guidance on parsing/typing (netip, enums, stringly-typed identifiers).
.github/skills/acn-go-platform-abstraction/SKILL.md Adds guidance for Linux/Windows splits via build tags and boundary placement.
.github/skills/acn-go-interfaces-dependencies/SKILL.md Adds guidance on interface placement, dependency direction, and handler surfaces.
.github/skills/acn-go-http-api-contracts/SKILL.md Adds guidance on HTTP/REST contract shape and handler design.
.github/skills/acn-go-errors-logging/SKILL.md Adds guidance on Go error strings, zap discipline, and operational signal density.
.github/skills/acn-go-design-boundaries/SKILL.md Adds guidance on scenario-vs-behavior boundaries, purity, batching, and stability.
.github/skills/acn-go-control-plane-contracts/SKILL.md Adds guidance on CRD/status/response-code contract discipline and generated artifacts.
.github/skills/acn-go-context-lifecycle/SKILL.md Adds guidance on context ownership, goroutine lifecycle, errgroup, and timers.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/skills/acn-go-types-parsing/SKILL.md Outdated
Comment thread .github/skills/acn-go-control-plane-contracts/SKILL.md Outdated
Comment thread .github/copilot-instructions.md Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
@rbtr rbtr self-assigned this Apr 15, 2026
@rbtr rbtr requested a review from nairashu April 15, 2026 16:36
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
@rbtr rbtr enabled auto-merge April 15, 2026 17:10
@rbtr
Copy link
Copy Markdown
Collaborator Author

rbtr commented Apr 15, 2026

/azp run Azure Container Networking PR

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants