Open
Conversation
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds repository-wide and CNS-specific agent guidance plus a set of Go-focused “skills” documents intended to drive consistent code quality and maintainability for contributors/AI coding agents.
Changes:
- Introduces root + CNS-scoped
agents.mdinstruction docs and wires them into Copilot/Claude instruction entrypoints. - Adds multiple
.github/skills/acn-go-*skill documents covering Go API contracts, design boundaries, context lifecycle, platform abstraction, errors/logging, interfaces/dependencies, and types/parsing. - Documents CNS architecture context and recommended repo skills/tests for CNS work.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
cns/agents.md |
Adds CNS-specific architecture/flow notes and prescriptive skill mapping for code areas. |
agents.md |
Adds general agent behavioral guidelines to reduce common implementation mistakes. |
CLAUDE.md |
Establishes a single instruction entrypoint for Claude-based agents. |
.github/copilot-instructions.md |
Establishes a single instruction entrypoint for GitHub Copilot. |
.github/skills/acn-go-types-parsing/SKILL.md |
Adds guidance on parsing/typing (netip, enums, stringly-typed identifiers). |
.github/skills/acn-go-platform-abstraction/SKILL.md |
Adds guidance for Linux/Windows splits via build tags and boundary placement. |
.github/skills/acn-go-interfaces-dependencies/SKILL.md |
Adds guidance on interface placement, dependency direction, and handler surfaces. |
.github/skills/acn-go-http-api-contracts/SKILL.md |
Adds guidance on HTTP/REST contract shape and handler design. |
.github/skills/acn-go-errors-logging/SKILL.md |
Adds guidance on Go error strings, zap discipline, and operational signal density. |
.github/skills/acn-go-design-boundaries/SKILL.md |
Adds guidance on scenario-vs-behavior boundaries, purity, batching, and stability. |
.github/skills/acn-go-control-plane-contracts/SKILL.md |
Adds guidance on CRD/status/response-code contract discipline and generated artifacts. |
.github/skills/acn-go-context-lifecycle/SKILL.md |
Adds guidance on context ownership, goroutine lifecycle, errgroup, and timers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Collaborator
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Distills years of repo code changes, review feedback, and comments in to guiding Agent skills focused on Go code quality and forward-looking maintainability.
Issue Fixed:
Requirements:
Notes: