Skip to content

[test] add additional SD tbor command fuzz targets - #783

Open
David Zimmermann (zimmy87) wants to merge 9 commits into
mainfrom
user/v-davidz/add_tbor_sd_2
Open

David Zimmermann (zimmy87) wants to merge 9 commits into
mainfrom
user/v-davidz/add_tbor_sd_2

Conversation

@zimmy87

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI balanced review requested due to automatic review settings October 7, 2026 22:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The remote-restore fuzzer incorrectly accepts driver failures as expected mutation rejections.

1 open finding
What changed in this PR

Adds fuzz coverage for security-domain TBOR sealing-key generation and backup restoration flows.

Changes:

  • Adds three stateful SD command fuzz targets.
  • Exercises valid requests and mutations across sessions, policies, evidence, and backups.
  • Registers the new fuzz binaries.
File Description
fuzz/​Cargo.toml Registers three fuzz targets.
fuzz/​fuzz_targets/​common.rs Formatting-only policy construction change.
fuzz_tbor_sd_sealing_key_gen.rs Fuzzes sealing-key generation.
fuzz_tbor_sd_restore_remote_backup.rs Fuzzes remote backup restoration.
fuzz_tbor_sd_restore_peer_backup.rs Fuzzes peer backup restoration.

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Comment thread fuzz/fuzz_targets/ddi/tbor/fuzz_tbor_sd_restore_remote_backup.rs Outdated
Comment thread fuzz/fuzz_targets/ddi/tbor/fuzz_tbor_sd_restore_peer_backup.rs Fixed
Comment thread fuzz/fuzz_targets/ddi/tbor/fuzz_tbor_sd_sealing_key_gen.rs Fixed
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 8, 2026 05:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The remote-backup fuzz target contains an extra closing brace that prevents compilation.

0 open findings

1 resolved since last review

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Comment thread fuzz/fuzz_targets/ddi/tbor/fuzz_tbor_sd_restore_peer_backup.rs Fixed
Comment thread fuzz/fuzz_targets/ddi/tbor/fuzz_tbor_sd_restore_remote_backup.rs Fixed
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 8, 2026 06:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The remote-backup fuzz target has an extra closing brace that prevents compilation.

0 open findings

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Copilot AI balanced review requested due to automatic review settings October 8, 2026 06:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The new targets consistently model command prerequisites, expected failures, and cleanup without identified correctness issues.

0 open findings

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

@zimmy87
David Zimmermann (zimmy87) marked this pull request as ready for review October 8, 2026 06:47
Copilot AI balanced review requested due to automatic review settings October 9, 2026 19:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The sealing-key fuzz binary must opt out of normal Cargo test-target builds.

1 open finding

🧠 Review effort: Balanced

Comment thread fuzz/Cargo.toml
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 9, 2026 19:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The stateful cryptographic backup fixtures and mutation oracles warrant final human validation.

0 open findings

1 resolved since last review

🧠 Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants