Repository navigation
[test] add SD tbor command fuzz targets - #770
Open
David Zimmermann (zimmy87) wants to merge 14 commits into
Open
David Zimmermann (zimmy87) wants to merge 14 commits into
David Zimmermann (zimmy87) wants to merge 14 commits into
Conversation
Copilot started reviewing on behalf of
David Zimmermann (zimmy87)
October 6, 2026 04:43
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The large security-sensitive cryptographic fuzz fixtures warrant final human validation and execution against supported backends.
Review effort: Balanced
Findings: None
What changed in this PR
Adds structured fuzz coverage for four Security Domain TBOR backup commands, including valid, lifecycle, evidence, policy, and tampering scenarios.
Changes:
- Adds fuzz targets for peer creation, remote creation, local restoration, and remote resealing.
- Registers targets and adds peer-backup corpus generation.
- Extends peer-backup integration coverage for repetition and policy mismatch.
| File | Description |
|---|---|
fuzz/scripts/generate_sd_create_peer_backup_corpus.ps1 |
Generates peer-backup scenario seeds. |
fuzz/fuzz_targets/ddi/tbor/fuzz_tbor_sd_restore_local_backup.rs |
Fuzzes local backup restoration. |
fuzz/fuzz_targets/ddi/tbor/fuzz_tbor_sd_reseal_remote_backup.rs |
Fuzzes remote backup resealing. |
fuzz/fuzz_targets/ddi/tbor/fuzz_tbor_sd_create_remote_backup.rs |
Fuzzes remote backup creation. |
fuzz/fuzz_targets/ddi/tbor/fuzz_tbor_sd_create_peer_backup.rs |
Fuzzes peer backup creation. |
fuzz/fuzz_targets/common.rs |
Reformats policy fixture construction. |
fuzz/Cargo.toml |
Registers the four fuzz binaries. |
ddi/tbor/types/tests/commands/sd_create_peer_backup.rs |
Tests repeatability and policy rejection. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot started reviewing on behalf of
David Zimmermann (zimmy87)
October 6, 2026 18:34
View session
Copilot started reviewing on behalf of
David Zimmermann (zimmy87)
October 6, 2026 19:08
View session
…uzz_tbor_sd_reseal_remote_backup
Copilot started reviewing on behalf of
David Zimmermann (zimmy87)
October 6, 2026 20:27
View session
David Zimmermann (zimmy87)
marked this pull request as ready for review
October 6, 2026 20:41
Rajesh Gali (rajesh-gali)
requested changes
Oct 6, 2026
Copilot started reviewing on behalf of
David Zimmermann (zimmy87)
October 7, 2026 20:36
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Ephemeral-scope peer-backup cases reuse a masked key after its masking key is regenerated.
1 open finding
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Co-authored-by: zimmy87 <5205889+zimmy87@users.noreply.github.com>
Copilot started reviewing on behalf of
David Zimmermann (zimmy87)
October 7, 2026 20:46
View session
…azihsm-sdk into user/v-davidz/add_tbor_sd
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The new fuzz targets cover valid, lifecycle, scope, evidence, and tampering paths without unresolved correctness issues.
0 open findings
1 resolved since last review
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Copilot started reviewing on behalf of
David Zimmermann (zimmy87)
October 9, 2026 18:45
View session
Update comment to clarify that SdSealingKeyGen returns a partition-scoped masked-key. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
David Zimmermann (zimmy87)
October 9, 2026 19:01
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.