WpEndpointArgs now accepts all JSON types
#1072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the `get` function to get a specific argument definition.
jkmassel
approved these changes
Dec 19, 2025
Contributor
jkmassel
left a comment
jkmassel
left a comment
There was a problem hiding this comment.
Nice fix, and thanks for the test.
I wonder if WpEndpoint.args should just be JsonValue and consumers can work with it however they want?
Contributor
Author
|
I don't know how to answer that 😄 , as I'm not sure how the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a plugin (The Event Tickets plugin) has an unexpected
argsin itswp-jsonresponse, which causes theWpApiDetailsparsing failure. That means any site with that plugin won't be able to sign in with application passwords from the app.