fix: resolve InternalServerError variant mismatch and staking auth IDOR#633
Open
Hovibby wants to merge 1 commit into
Open
fix: resolve InternalServerError variant mismatch and staking auth IDOR#633Hovibby wants to merge 1 commit into
Hovibby wants to merge 1 commit into
Conversation
- Change ApiError::InternalServerError from unit to tuple variant (String)
to fix compile-time error across gas_estimation_handler, staking_service,
and analytics_service
- Sanitize error responses: stop echoing internal error details to clients
- Remove user_id from StakeBody/ClaimBody; identity now sourced from JWT
claims only, preventing users from acting on behalf of other accounts
- Validate stellar_address against wallets.stellar_public_key for the
authenticated user on stake and claim endpoints (403 on mismatch)
- Protect unstake/{user_id} path param against JWT identity (403 on mismatch)
- Add tracing::error! logging in gas estimation handler before 500 response
- Add unit tests: unauthenticated stake -> 401, wrong-user unstake -> 403
|
Someone is attempting to deploy a commit to the paul joseph's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #630
closes #631
Change ApiError::InternalServerError from unit to tuple variant (String)
to fix compile-time error across gas_estimation_handler, staking_service,
and analytics_service
Sanitize error responses: stop echoing internal error details to clients
Remove user_id from StakeBody/ClaimBody; identity now sourced from JWT
claims only, preventing users from acting on behalf of other accounts
Validate stellar_address against wallets.stellar_public_key for the
authenticated user on stake and claim endpoints (403 on mismatch)
Protect unstake/{user_id} path param against JWT identity mismatch (403)
Add tracing::error! logging in gas estimation handler before 500 response
Add unit tests: unauthenticated stake -> 401, wrong-user unstake -> 403