feat(auth): migrate Login & Register to React Hook Form + Zod (#509)#528
Open
Rufai-Ahmed wants to merge 1 commit into
Open
feat(auth): migrate Login & Register to React Hook Form + Zod (#509)#528Rufai-Ahmed wants to merge 1 commit into
Rufai-Ahmed wants to merge 1 commit into
Conversation
|
@Rufai-Ahmed is attempting to deploy a commit to the paul joseph's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the core auth forms from manual
useStatevalidation to React Hook Form + Zod, establishing a consistent, type-safe pattern for the rest of the app's forms (#509).Changes
react-hook-form+@hookform/resolvers.LoginFormandRegisterFormnow useuseForm+zodResolver, reusing the existing schemas inlib/validations/auth.ts(loginSchema,registerSchema) instead of hand-rolledvalidate()/safeParse.LoginFormInputtype so therememberMedefault is handled correctly across Zod's input/output transform (useForm<LoginFormInput, _, LoginFormData>).aria-invalid/aria-describedby, and error messaging.Scope
The issue lists "all forms" plus analytics/perf/docs. This PR converts the two core auth forms as the canonical RHF+Zod template; the remaining forms (password reset, tournament registration, withdraw modal, contact) can adopt the same pattern in follow-ups.
Testing
tsc --noEmitis clean forLoginForm.tsx,RegisterForm.tsx, andvalidations/auth.ts. (The repo has unrelated pre-existing type errors in other areas.)Closes #509