feat(event): implement cancel_event function with authorization check… #1019#1072
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@Awointa Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1019
Summary
Adds cancel_event(env, caller, event_id) to the creator-event-manager
contract, allowing the event creator to irreversibly cancel an event before it
is finalized.
Changes
src/event.rs
finalized or already cancelled, calls the existing Event::cancel() method,
persists the updated event, and emits ("event", "cancelled").
src/lib.rs
mapping all error variants to panic strings consistent with the rest of the
contract.
tests/cancel_event_tests.rs (new file)
= false.
call.
create_match.
Acceptance criteria
┌──────────────────────────────────┬──────────────────────────────────────┐
│ Criterion │ Covered by │
├──────────────────────────────────┼──────────────────────────────────────┤
│ Only creator can cancel │ test_cancel_event_non_creator_r │
│ │ ejected │
├──────────────────────────────────┼──────────────────────────────────────┤
│ Cancellation is irreversible │ test_cancel_event_already_cancelled │
├──────────────────────────────────┼──────────────────────────────────────┤
│ Cancelled events block │ test_join_cancelled_event_rejected │
│ join_event │ │
├──────────────────────────────────┼──────────────────────────────────────┤
│ Cancelled events block │ test_create_match_on_cancelled_ │
│ create_match │ event_rejected │
├──────────────────────────────────┼──────────────────────────────────────┤
│ ("event", "cancelled") emitted │ cancel_event impl │
│ on success │ │
└──────────────────────────────────┴──────────────────────────────────────┘
Notes
AlreadyFinalized (error code 18) was already present in EventError — no new
variant needed for that case. The Unauthorized variant (21) is the only
addition to the error enum.