Repository navigation
feat(core,gui): allow middle click gesture mode - #1738
Open
PedroDiogo wants to merge 4 commits into
Open
PedroDiogo wants to merge 4 commits into
PedroDiogo wants to merge 4 commits into
Conversation
PedroDiogo
marked this pull request as ready for review
October 11, 2026 17:38
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge prerequisite
Merge #1380 before this PR. It adds Middle Click to macOS HID++ gesture capture. This PR exposes Middle Click gesture mode in the UI; it does not include that capture fix. Without #1380, the UI can offer gesture mode while gestures still fail on the affected macOS path, including the MX Ergo Bluetooth connection tested here.
The successful hardware test used both changes. Once #1380 lands, rebase this PR onto the updated base before merging.
Summary
Allow Middle Click to enter gesture mode from the Buttons inspector. In 0.8.13, existing middle-click gesture maps are preserved, but the UI prevents creating or re-enabling them.
Changes
openlogi-core: permit Middle Click as a gesture source; verify a fresh map retains the native middle-click tap and projects its swipe actions.openlogi-desktop: expose the existing gesture editor for Middle Click; cover creating, editing, disabling, and re-enabling its map.openlogi-agent-core: update the hook documentation to match the supported controls.Testing
Host: macOS, Apple Silicon; Rust 1.98.0.
Checks previously passed with a temporary fix for an unrelated baseline camera lint (2,024 tests, including doctests):
The unrelated camera fix is excluded from the final diff. On the final tree, workspace Clippy fails on the unchanged
openlogi-camera/src/uvc_macos.rs:97(trivially_copy_pass_by_ref). The contributor authorized skipping only that pre-push Clippy hook to remove the unrelated change; all other applicable hooks, including formatting, ast-grep, and rustdoc, passed. The full test suite and wasm checks above ran before this removal; the gesture code is unchanged.Hardware: MX Ergo over Bluetooth. With this UI change and the middle-click HID++ ownership change already proposed in #1380, holding Middle Click, rolling the trackball upward, and releasing opened Mission Control. The screenshot is from that combined development build. This PR alone does not claim to fix the macOS sender-less event/capture problem.
To reproduce: select Middle Click in Buttons, enable gesture mode, assign Up to Mission Control, and hold the wheel button while rolling the trackball upward. On the affected macOS path, also apply #1380. Verify that disabling and re-enabling gesture mode preserves the direction assignments.
Windows/Linux hardware and other gesture directions were not runtime-tested.