Repository navigation
fix(gui): capture custom shortcuts with distinct numpad keys - #1132
Closed
tournierjc wants to merge 2 commits into
Closed
tournierjc wants to merge 2 commits into
tournierjc wants to merge 2 commits into
Conversation
Greptile SummaryThe PR adds GPUI-based shortcut capture with distinct numpad digit usages and extends cross-platform injection mappings for the newly recordable keys.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| crates/openlogi-desktop/src/features/action_ring.rs | The editor now renders the effective application-scoped ring layout and commits captured shortcuts through the existing scoped action-ring state path. |
| crates/openlogi-desktop/src/ui/shortcut_capture.rs | Introduces the reusable GPUI shortcut-capture control used by binding editors. |
| crates/openlogi-core/src/binding/key_combo.rs | Extends GPUI key-name conversion and HID usage labeling for keypad and navigation keys. |
| crates/openlogi-inject/src/inject.rs | Expands Windows HID mappings and distinguishes keypad Enter as an extended key. |
| crates/openlogi-inject/src/inject/windows.rs | Propagates Windows extended-key identity through regular and held shortcut injection paths. |
| Cargo.toml | Temporarily redirects GPUI dependencies to the patched numpad-aware upstream fork. |
Reviews (3): Last reviewed commit: "fix(gui,inject): honor per-app ring layo..." | Re-trigger Greptile
Author
Record keyboard shortcuts from GPUI keystrokes in the button inspector, with kp0-kp9 identity preserved via a patched GPUI fork. Depends on zed-industries/zed#63402 (Fixes zed-industries/zed#11948). Alternative approach to AprilNEA#971. Co-authored-by: Cursor <cursoragent@cursor.com>
Greptile: show the scoped Actions Ring layout in the editor instead of always reading default, and set KEYEVENTF_EXTENDEDKEY for HID 0x58 so keypad Enter stays distinct from main Enter when injecting shortcuts. Co-authored-by: Cursor <cursoragent@cursor.com>
tournierjc
force-pushed
the
upstream/shortcut-capture
branch
from
August 29, 2026 16:06
500296e to
f0c4d0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Record custom keyboard shortcuts from GPUI keystrokes in the button inspector, mapping numpad digits to distinct HID usages (
kp0–kp9).GPUI dependency
Numpad identity requires a GPUI platform fix upstream in Zed:
Keystroke.keykp0–kp9on Linux/macOS/WindowsThis PR patches GPUI from
tournierjc/zedbranchopenlogi/numpad-digit-keysuntil #63402 lands.Relation to OpenLogi#971
AprilNEA/OpenLogi#971 proposes agent-backed shortcut recording (Fixes #573). This PR uses GPUI keystroke capture in the desktop UI instead — an alternative approach worth comparing before both land.
Testing
Verify numpad digits record as
kp0–kp9on Linux after the GPUI patch.Made with Cursor