fix: handle list API responses for controller 26.7+ compatibility (v1.8.2) - #197
Merged
alexafshar merged 1 commit intoAug 18, 2026
Conversation
Aligns thresholds file version with tool version so users running pre-built executables or source from the 1.8.2 release do not hit a version mismatch error on startup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #193 and adds compatibility for controller 26.7+.
This PR incorporates two fixes for AppDynamics controller API response format changes where endpoints now return a plain list instead of the expected
{"data": [...]}dict, causing a fatalTypeErrorthat aborted the entire job.Changes
From #194 (fix #193):
AppDService.getServers— guardserverAvailabilityResult.datawithisinstance(dict)check; default availability toNonewith a warning logHealthRulesAndAlertingAPM/BRUM/MRUM— guardeventCounts[idx].datawith error/type check; default to zero violations soanalyze()proceedsNew (controller 26.7+):
AppDService.getAppServerAgentsIds—POST /controller/restui/agents/list/appserver/idsnow returns a plain list on 26.7+; guard withisinstancecheck to support both old and new formatsDefaultThresholds.json— version bumped to1.8.2to match tool versionCompatibility