Fix/bound pause reason#61
Merged
Merged
Conversation
Add MAX_REASON_LEN constant (256) and SLAError::InvalidInput variant. Validate reason.len() before persisting PauseInfo, returning InvalidInput on violation instead of silently accepting multi-kilobyte payloads.
Verifies that a 257-byte pause reason triggers a HostError panic (SLAError::InvalidInput).
Line break in assignment violated rustfmt. Merged to single line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31
Here's a summary of what was done:
Changes in
apexchainx_calculator/src/lib.rs:MAX_REASON_LEN = 256constant at line 59SLAError::InvalidInput = 16variant at line 254pause()at lines 790-792 — returnsErr(SLAError::InvalidInput)ifreason.len() > 256Changes in
apexchainx_calculator/src/tests.rs:test_pause_rejects_long_reasontest at line 1922 — verifies that a 257-byte reason triggers aHostError2 commits created:
af6559c—feat: bound pause reason to 256 bytes with SLAError::InvalidInput (#68)85ea71b—test: add test_pause_rejects_long_reason for reason >256 bytes (#68)Note:
cargo buildandcargo check --testspass. The test binary cannot link on this Windows GNU environment due to a pre-existingbacktracecrate dlltool incompatibility (unrelated to these changes).