Skip to content

feat(a11y): accessible feedback on certificate retirement actions#688

Merged
AnnabelJoe merged 2 commits into
AnnabelJoe:mainfrom
georgeefaith:feat/487-retire-modal-a11y
Jun 27, 2026
Merged

feat(a11y): accessible feedback on certificate retirement actions#688
AnnabelJoe merged 2 commits into
AnnabelJoe:mainfrom
georgeefaith:feat/487-retire-modal-a11y

Conversation

@georgeefaith

Copy link
Copy Markdown
Contributor

Summary

Closes #487

Changes

  • aria-live="polite" region (visually hidden) announces success and error messages to screen readers without interrupting ongoing interactions.
  • role="alert" inline error banner — immediately announced by screen readers on failure; only rendered when an error exists.
  • role="status" success view — replaces the form after successful retirement with a CheckCircle icon and confirmation message.
  • aria-busy on the submit button signals the loading state to assistive technology.
  • All interactive elements disabled (submit, cancel, close ×, textarea) while the request is in-flight to prevent double-submission.
  • Error is caught from onConfirm() and surfaced both visually and via the aria-live region — previously errors were swallowed silently.

Acceptance criteria

  • Retirement modal has aria-live success state
  • Button state changes reflect progress
  • Errors are shown in a way that screen readers can detect

- aria-live='polite' region announces success and error messages to
  screen readers without interrupting the user mid-flow
- role='alert' on inline error banner for immediate screen reader
  announcement on failure
- role='status' + CheckCircle success state replaces the form on
  completion so screen readers detect the outcome
- aria-busy on submit button signals loading state to assistive tech
- Close and Cancel buttons disabled while submitting; textarea also
  disabled during in-flight request
- Error caught from onConfirm() and surfaced visually and via aria-live

Closes AnnabelJoe#487
@drips-wave

drips-wave Bot commented Jun 26, 2026

Copy link
Copy Markdown

@georgeefaith Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@AnnabelJoe AnnabelJoe merged commit 3d67252 into AnnabelJoe:main Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add accessible feedback on certificate retirement actions

2 participants