fix: expire sessions at TTL boundary so done_ttl_seconds=0 works#13
Open
Anai-Guo wants to merge 1 commit into
Open
fix: expire sessions at TTL boundary so done_ttl_seconds=0 works#13Anai-Guo wants to merge 1 commit into
Anai-Guo wants to merge 1 commit into
Conversation
SessionRegistry.cleanup used a strict `>` comparison, so a TTL of 0
("expire immediately") never removed sessions when the elapsed time
since completion was below the system clock's resolution. On coarse
clocks this made test_cleanup_removes_old_done_sessions fail
deterministically. Use `>=` so age-reached-TTL counts as expired.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
自动维护改动
类型：维护（测试稳定性 / bug 修复）
改动：SessionRegistry.cleanup 用
>=替代严格>，使done_ttl_seconds=0（立即过期）在粗粒度系统时钟下也能正确移除会话。测试：通过（270 passed, 1 skipped；此前
test_cleanup_removes_old_done_sessions在 Windows 上确定性失败，现已修复）本 PR 由每日维护任务生成，请人工 review 后再合并。
🤖 Generated with Claude Code