Skip to content

Revert "Commit hook: Warn about files with significant changes in next (#4095)"#4243

Merged
olemartinorg merged 1 commit into
mainfrom
revert-4095-chore/monorepo-commit-hook
Jun 1, 2026
Merged

Revert "Commit hook: Warn about files with significant changes in next (#4095)"#4243
olemartinorg merged 1 commit into
mainfrom
revert-4095-chore/monorepo-commit-hook

Conversation

@olemartinorg
Copy link
Copy Markdown
Contributor

@olemartinorg olemartinorg commented Jun 1, 2026

Reverts #4095

Summary by CodeRabbit

Chores

  • Simplified the pre-commit hook configuration by removing monorepo path validation checks and streamlining the commit validation process to run linting directly.

@olemartinorg olemartinorg added ignore-for-release Pull requests to be ignored in release notes backport-ignore This PR is a new feature and should not be cherry-picked onto release branches labels Jun 1, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 1, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 22cb303b-ee75-4f83-8e60-baa2938e53f8

📥 Commits

Reviewing files that changed from the base of the PR and between 557ab7e and fce6ef8.

📒 Files selected for processing (2)
  • .husky/pre-commit
  • .husky/pre-commit-check-monorepo-paths
💤 Files with no reviewable changes (2)
  • .husky/pre-commit
  • .husky/pre-commit-check-monorepo-paths

📝 Walkthrough

Walkthrough

The pre-commit Git hook is simplified to remove a monorepo path validation step. The hook no longer invokes a check script that blocked commits when staged files matched a remote list of changed/refactored paths. The associated shell script is deleted.

Changes

Pre-commit hook simplification

Layer / File(s) Summary
Remove monorepo path validation from pre-commit flow
.husky/pre-commit, .husky/pre-commit-check-monorepo-paths
The pre-commit hook removes its invocation of the monorepo path check script. The check script file, which previously fetched remote paths and blocked commits on matches, is deleted entirely.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete. While it mentions the revert target, it lacks detailed explanation of changes, testing verification, and required checklist items specified in the repository template. Add a detailed description of what was reverted, mark appropriate testing and verification checkboxes, and add required labels (kind/* and backport* are partially addressed but need clarity).
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: reverting a previous commit hook warning feature, which matches the actual removal of the monorepo path check and the pre-commit hook modification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-4095-chore/monorepo-commit-hook

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@olemartinorg olemartinorg added the squad/utforming Issues that belongs to the named squad. label Jun 1, 2026
@olemartinorg olemartinorg moved this to 🔎 In review in Team Altinn Studio Jun 1, 2026
@olemartinorg olemartinorg changed the title Revert "Commit hook: Warn about files with significant changes in next" Revert "Commit hook: Warn about files with significant changes in next (#4095)" Jun 1, 2026
@olemartinorg olemartinorg merged commit 62dcc77 into main Jun 1, 2026
7 checks passed
@olemartinorg olemartinorg deleted the revert-4095-chore/monorepo-commit-hook branch June 1, 2026 12:00
@github-project-automation github-project-automation Bot moved this from 🔎 In review to ✅ Done in Team Altinn Studio Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-ignore This PR is a new feature and should not be cherry-picked onto release branches ignore-for-release Pull requests to be ignored in release notes squad/utforming Issues that belongs to the named squad.

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants