Fixing 'Edit' button in RepeatingGroup table summaries #3389
Merged
Conversation
added 2 commits
May 25, 2025 14:21
…rst non-hidden child in the repeating group, with preference to table-nodes, then other children, then the repeating group itself.
paal2707
approved these changes
May 30, 2025
# Conflicts: # src/layout/RepeatingGroup/Summary2/RepeatingGroupTableSummary/RepeatingGroupTableSummary.tsx
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
The 'Edit' button here simply pointed to the first table component. If that component is hidden (like it is in the app described in #3363), navigation will not even attempt to go to the correct page. So, instead of navigating to the first component, this change will make it look for the first non-hidden component inside the repeating group row to navigate to.
Related Issue(s)
Verification/QA
kind/*andbackport*label to this PR for proper release notes grouping