Skip to content

Fixing 'Edit' button in RepeatingGroup table summaries #3389

Merged
olemartinorg merged 3 commits into
mainfrom
bug/editHiddenNode
May 30, 2025
Merged

Fixing 'Edit' button in RepeatingGroup table summaries #3389
olemartinorg merged 3 commits into
mainfrom
bug/editHiddenNode

Conversation

@olemartinorg
Copy link
Copy Markdown
Contributor

Description

The 'Edit' button here simply pointed to the first table component. If that component is hidden (like it is in the app described in #3363), navigation will not even attempt to go to the correct page. So, instead of navigating to the first component, this change will make it look for the first non-hidden component inside the repeating group row to navigate to.

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* and backport* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

Ole Martin Handeland added 2 commits May 25, 2025 14:21
…rst non-hidden child in the repeating group, with preference to table-nodes, then other children, then the repeating group itself.
@olemartinorg olemartinorg added kind/bug Something isn't working backport This PR should be cherry-picked onto older release branches labels May 25, 2025
# Conflicts:
#	src/layout/RepeatingGroup/Summary2/RepeatingGroupTableSummary/RepeatingGroupTableSummary.tsx
@sonarqubecloud
Copy link
Copy Markdown

@olemartinorg olemartinorg merged commit 68fec57 into main May 30, 2025
15 checks passed
@olemartinorg olemartinorg deleted the bug/editHiddenNode branch May 30, 2025 10:03
@cammiida cammiida removed the backport This PR should be cherry-picked onto older release branches label Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit button for rep. group doesnt work on the summary page

3 participants