Skip to content

Chore/update ds#3231

Merged
Magnusrm merged 201 commits into
mainfrom
chore/update-ds
Jun 24, 2025
Merged

Chore/update ds#3231
Magnusrm merged 201 commits into
mainfrom
chore/update-ds

Conversation

@Magnusrm
Copy link
Copy Markdown
Contributor

@Magnusrm Magnusrm commented Apr 3, 2025

Description

Related Issue(s)

Verification/QA

  • Manual functionality testing

    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests

    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)

    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs

    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio

    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board

    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels

    • I have added a kind/* and backport* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@Magnusrm
Copy link
Copy Markdown
Contributor Author

/publish

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 16, 2025

PR release:

  • <link rel="stylesheet" type="text/css" href="https://altinncdn.no/toolkits/altinn-app-frontend/4.20.1-pr.1523.update-ds.23dbf367/altinn-app-frontend.css">
  • <script src="https://altinncdn.no/toolkits/altinn-app-frontend/4.20.1-pr.1523.update-ds.23dbf367/altinn-app-frontend.js"></script>

⚙️ Building...
✅ Done!

@olemartinorg olemartinorg self-requested a review June 19, 2025 08:47
Copy link
Copy Markdown
Contributor

@olemartinorg olemartinorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phenomenal stuff! 🚀 🌔 A couple of nitpicks from me, but this is a solid piece of work -- good job! 👏 👏 👏

Comment thread .github/pull_request_template.md Outdated
Comment thread src/layout/RepeatingGroup/Pagination/RepeatingGroupPagination.tsx
Comment thread webpack.config.production.js
@olemartinorg
Copy link
Copy Markdown
Contributor

We should also take a look at all the issues linked to #2600 that we might want to close as solved after this. 🤔 I saw at least one thing I remember being and issue which you seem to have fixed here (I didn't test, just read the code).

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
31.34% Condition Coverage on New Code (required ≥ 45%)

See analysis details on SonarQube Cloud

@Magnusrm Magnusrm merged commit 98629b8 into main Jun 24, 2025
14 of 15 checks passed
@Magnusrm Magnusrm deleted the chore/update-ds branch June 24, 2025 12:03
@olemartinorg olemartinorg mentioned this pull request Jun 24, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-ignore This PR is a new feature and should not be cherry-picked onto release branches kind/other Pull requests containing chores/repo structure/other changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Designsystemet to latest v1

4 participants