Skip to content

ci: no CI job runs typecheck, and main currently fails it #1412

Description

@ralphstodomingo

What

No CI job runs the compiler. bun turbo typecheck runs only in release.yml and in the local pre-push hook. The CI "TypeScript" job runs the test suite, which bun executes without type-checking.

So main currently fails typecheck, and CI is green:

test/session/trace-context-loop.test.ts(25,18): error TS2739: Type '{ status: ...; entry: ... }'
is missing the following properties from type 'Interface': listMeta, snapshot
Failed: @altimateai/altimate-code#typecheck

#1308 added listMeta and snapshot to the MCP service interface and updated the mocks that existed then. #1400, open at the same time, added a new mock without them. Each PR passed on its own; together they broke typecheck on main at f8191ab.

Why it matters

Reproduce

On main: bun install && bun turbo typecheck --continue. 12 of 13 packages pass; @altimateai/altimate-code fails with the error above.

Suggested fix

Add the two members to that mock, and add a CI job that runs bun turbo typecheck on pull requests and on pushes to main, so the next break shows up in CI.

Activity

  1. ralphstodomingo commented on Oct 6, 2026

    @ralphstodomingo
    ContributorAuthor

    Update: the type error itself was fixed on main by #1405, which added the two missing mock members. #1413 now only adds the Typecheck job. While updating it I found that its earlier copy of the same mock fix and main's copy merged without a git conflict but with duplicate keys (TS1117), the kind of break that only shows up once two changes meet, which the job checks for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions