What
No CI job runs the compiler. bun turbo typecheck runs only in release.yml and in the local pre-push hook. The CI "TypeScript" job runs the test suite, which bun executes without type-checking.
So main currently fails typecheck, and CI is green:
test/session/trace-context-loop.test.ts(25,18): error TS2739: Type '{ status: ...; entry: ... }'
is missing the following properties from type 'Interface': listMeta, snapshot
Failed: @altimateai/altimate-code#typecheck
#1308 added listMeta and snapshot to the MCP service interface and updated the mocks that existed then. #1400, open at the same time, added a new mock without them. Each PR passed on its own; together they broke typecheck on main at f8191ab.
Why it matters
Reproduce
On main: bun install && bun turbo typecheck --continue. 12 of 13 packages pass; @altimateai/altimate-code fails with the error above.
Suggested fix
Add the two members to that mock, and add a CI job that runs bun turbo typecheck on pull requests and on pushes to main, so the next break shows up in CI.
What
No CI job runs the compiler.
bun turbo typecheckruns only inrelease.ymland in the localpre-pushhook. The CI "TypeScript" job runs the test suite, which bun executes without type-checking.So
maincurrently fails typecheck, and CI is green:#1308 added
listMetaandsnapshotto the MCP service interface and updated the mocks that existed then. #1400, open at the same time, added a new mock without them. Each PR passed on its own; together they broke typecheck onmainat f8191ab.Why it matters
mainnow hasgit pushblocked by thepre-pushtypecheck, for code they did not touch. pre-push blocks pushes on a typecheck error in unmodified src/bus/global.ts #1165 is the same failure from an earlier break.Reproduce
On
main:bun install && bun turbo typecheck --continue. 12 of 13 packages pass;@altimateai/altimate-codefails with the error above.Suggested fix
Add the two members to that mock, and add a CI job that runs
bun turbo typecheckon pull requests and on pushes tomain, so the next break shows up in CI.