Task/3 24 2026 json schema for filters documentation edition#1682
Open
emily-howell wants to merge 28 commits intotask/3_19_2026-json-schema-for-filters-extended-editionfrom
Conversation
…' of github.com:Alpine-DAV/ascent into task/3_24_2026-json-schema-for-filters-documentation-edition
…' of github.com:Alpine-DAV/ascent into task/3_24_2026-json-schema-for-filters-documentation-edition
…' of github.com:Alpine-DAV/ascent into task/3_24_2026-json-schema-for-filters-documentation-edition
cyrush
reviewed
Apr 2, 2026
Member
cyrush
left a comment
cyrush
left a comment
There was a problem hiding this comment.
pass with a few of my suggestions
|
|
||
| Each helper returns a Conduit node that represents a schema fragment (see :ref:`param_schema`). | ||
| These fragments are typically inserted under ``param_schema["properties/<param_name>"]``. | ||
|
|
Member
There was a problem hiding this comment.
if we change to ref style args, we will need to update these docs
Member
Author
There was a problem hiding this comment.
I updated these docs to reflect the updated access pattern.
|
|
||
| .. code-block:: c++ | ||
|
|
||
| conduit::Node string_enum_schema(std::vector<std::string> options); |
Member
Author
There was a problem hiding this comment.
Updated to be conduit::Node &string_enum_schema(conduit::Node &schema_node, const std::vector<std::string> &options)
cyrush
reviewed
Apr 2, 2026
| Parameter Schemas for Validation and Surprise Checking | ||
| ====================================================== | ||
|
|
||
| The schema validator supports a focused subset of JSON Schema, along with a few Conduit-specific extensions under constraints. |
Member
There was a problem hiding this comment.
add link to json schema web resources
Member
Author
There was a problem hiding this comment.
Link added specifically to the top level references page: https://json-schema.org/understanding-json-schema/reference
…' of github.com:Alpine-DAV/ascent into task/3_24_2026-json-schema-for-filters-documentation-edition
…in upstream branches
…' of github.com:Alpine-DAV/ascent into task/3_24_2026-json-schema-for-filters-documentation-edition
…' of github.com:Alpine-DAV/ascent into task/3_24_2026-json-schema-for-filters-documentation-edition
…' of github.com:Alpine-DAV/ascent into task/3_24_2026-json-schema-for-filters-documentation-edition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds documentation and some final touches to the work completed in #1676 and #1663 and should be merged after them