-
Notifications
You must be signed in to change notification settings - Fork 77
Task/2 3 2025 json schema for filters #1663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
142cdd0
Save state post resolving conpilation bug :(
emily-howell f118307
Removing slide verify_params
emily-howell 736daf9
Adding some more json schema examples
emily-howell f6a94d2
Adding a schema validator for flow filters
emily-howell 6d5d6e1
Translating all filters in ascent_runtime_vtkh_filters to json schema…
emily-howell 0e05a88
Merge branch 'develop' of github.com:Alpine-DAV/ascent into task/2_3_…
emily-howell 96efc0e
Removing temporary helpers and cleaning up files
emily-howell d95a906
Seed should be seeds
emily-howell 69a3cbf
adding a detail namespace to validator
emily-howell 6bbaed1
Converting over the expression filters
emily-howell 5116d52
converting another file
emily-howell 47f6376
Trying to add some support for expressions again
emily-howell ddc3b89
Adding a way to pass our expression validator into the flow filter
emily-howell d068b1a
We have a valid expression checker!
emily-howell 3661bed
Integrating the expression checking into the vtkh number schemas :)
emily-howell ce5e626
Taking a pass at trying to get the JIT tests to pass
emily-howell fc14616
Require that either field or topology be given for a threshold filter
emily-howell 7208c66
Merge branch 'develop' of github.com:Alpine-DAV/ascent into task/2_3_…
emily-howell d4b004b
Merge branch 'develop' of github.com:Alpine-DAV/ascent into task/2_3_…
emily-howell 1d51baf
Fixing reflect filter
emily-howell f06051b
Fixing spelling error
emily-howell 1d2c3d9
Using refs to nodes instead of copying seperate nodes into tree
emily-howell 1e109b9
Generalizing the expression checking to any format checking
emily-howell 95cd1f1
Applied formatting fixes
emily-howell 0699c49
Merge branch 'develop' of github.com:Alpine-DAV/ascent into task/2_3_…
emily-howell 8f34331
Removing print statement added for debugging
emily-howell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only need init this once, but the cost isn't high so I am ok with keeping this