Replace 7k swap with Cetus, drop @7kprotocol/sdk-ts - #172
Conversation
|
operate.md review — head Verified-safe core (checked against Cetus SDK source, not the PR text): slippage is fraction 0–1 on both sides (no bps mismatch; fe already passes Advisory findings (non-blocking — no org repo currently calls the affected branch):
Recommend a small follow-up (fix |
jangid
left a comment
There was a problem hiding this comment.
operate.md: clean — CI green, slippage/min-out/recipient safety verified against the Cetus SDK source, deps registry-pinned. Advisory notes in the review comment (slippage-0 coercion, unconsumed no-coinIn branch semantics) — follow-up material, not blockers. Approvals: 2/2 — merge-ready.
Removes the last 7k usage (
zapOutWithdraw,getSwapTransactionBlock) in favor of the existing Cetus aggregator paths, deletessevenKSwap.ts, and drops@7kprotocol/sdk-ts(removes@flowx-finance/sdkand@bluefin-exchange/bluefin7k-aggregator-sdkfrom the tree with it). Addsbn.jsas a direct dep — it was only installed transitively via 7k but is imported bycetusSwap.ts.Breaking:
getSwapTransactionBlocknow takes a CetusRouterDataV3instead of a 7kQuoteResponse(consistent withgetSwapQuote'srawQuote).Verified: 58/58 tests, clean build, mainnet dry-runs of
zapOutWithdraw(stSUI→USDC) andgetSwapTransactionBlock(SUI→USDC) both succeed.