Fix Wii U build on macOS with devkitPPC r50 / GCC 14+ - #103
Open
patters-match wants to merge 1 commit into
Open
Conversation
- Makefile: check TARGET_WII_U before OSX_BUILD in platform detection chain to avoid misidentifying Wii U builds; guard SHA1SUM assignment - audio_sdl2.c: add missing <stdio.h> include required by GCC 14+ Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makefile:TARGET_WII_Uwas being evaluated afterOSX_BUILDin the platform detection chain, causing Wii U cross-compilation builds on macOS to be misidentified as native macOS builds. Reordered soTARGET_WII_Uis checked first. Also guards theSHA1SUMassignment to avoid errors when the tool is absent.src/pc/audio/audio_sdl2.c: adds missing#include <stdio.h>. Tested with devkitPPC r50; GCC 14+ no longer implicitly pulls it in via other headers.Additional macOS build notes
The following are required to build on macOS but are not part of this patch:
gmakeinstead ofmake:wuhbtoolto integrate the boot sound. I used Claude Code to rip the excellent boot screen and icon assets from the previously available.wuhbbinary, and Claude was able to extractbootSound.btsndfrom the Installer release once I had decrypted the files:Test plan
assemantics, unavailable on Darwin).