[PWGUD] use get track size and add flowMC#15679
Open
miedema-11 wants to merge 5 commits intoAliceO2Group:masterfrom
Open
[PWGUD] use get track size and add flowMC#15679miedema-11 wants to merge 5 commits intoAliceO2Group:masterfrom
miedema-11 wants to merge 5 commits intoAliceO2Group:masterfrom
Conversation
|
O2 linter results: ❌ 1 errors, |
github-actions
bot
changed the title
Collaborator
|
Error while checking build/O2Physics/o2 for 4eeefde at 2026-04-08 08:43: Full log here. |
amatyja
approved these changes
Apr 8, 2026
Collaborator
|
@miedema-11 This is a duplicate of #15626. Please do not do that. I made several suggestions on your previous PR which are now completely disconnected from this version and I have to visually compare both versions to see your implementation of my comments. |
vkucera
reviewed
Apr 8, 2026
| bool trackSelected(TTrack const& track) | ||
| { | ||
| // auto momentum = std::array<double, 3>{track.px(), track.py(), track.pz()}; | ||
| double pt = track.pt(); |
Comment on lines
+130
to
+146
| LorentzVectorM pMC(mcParticle.px(), mcParticle.py(), mcParticle.pz(), 0); // double phi = RecoDecay::phi(momentum); // focus on bulk: e, mu, pi, k, p | ||
| int pdgCode = std::abs(mcParticle.pdgCode()); | ||
| if (pdgCode == PDG_t::kElectron) | ||
| pMC.SetM(o2::constants::physics::MassElectron); | ||
| else if (pdgCode == PDG_t::kMuonMinus) | ||
| pMC.SetM(o2::constants::physics::MassMuon); | ||
| else if (pdgCode == PDG_t::kPiPlus) | ||
| pMC.SetM(o2::constants::physics::MassPionCharged); | ||
| else if (pdgCode == PDG_t::kKPlus) | ||
| pMC.SetM(o2::constants::physics::MassKaonCharged); | ||
| else if (pdgCode == PDG_t::kProton) | ||
| pMC.SetM(o2::constants::physics::MassProton); | ||
| else | ||
| continue; | ||
|
|
||
| double pt = pMC.Pt(); | ||
| double eta = pMC.Eta(); |
Collaborator
There was a problem hiding this comment.
All this is completely useless. Transverse momentum and pseudorapidity do not depend on the mass.
Comment on lines
+191
to
+207
| auto mcParticle = track.udMcParticle(); | ||
| int pdgCode = std::abs(mcParticle.pdgCode()); | ||
| if (pdgCode == PDG_t::kElectron) | ||
| recoMC.SetM(o2::constants::physics::MassElectron); | ||
| else if (pdgCode == PDG_t::kMuonMinus) | ||
| recoMC.SetM(o2::constants::physics::MassMuon); | ||
| else if (pdgCode == PDG_t::kPiPlus) | ||
| recoMC.SetM(o2::constants::physics::MassPionCharged); | ||
| else if (pdgCode == PDG_t::kKPlus) | ||
| recoMC.SetM(o2::constants::physics::MassKaonCharged); | ||
| else if (pdgCode == PDG_t::kProton) | ||
| recoMC.SetM(o2::constants::physics::MassProton); | ||
| else | ||
| continue; | ||
|
|
||
| double pt = recoMC.Pt(); | ||
| double eta = recoMC.Eta(); |
Collaborator
|
Hi @miedema-11, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.