[PWGJE,Infrastructure] Create qg tree creator#15555
Open
Physicistdana wants to merge 27 commits intoAliceO2Group:masterfrom
Open
[PWGJE,Infrastructure] Create qg tree creator#15555Physicistdana wants to merge 27 commits intoAliceO2Group:masterfrom
Physicistdana wants to merge 27 commits intoAliceO2Group:masterfrom
Conversation
Physicistdana
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa,
mhemmer-cern,
nzardosh and
raymondEhlers
as code owners
github-actions
bot
changed the title
Physicistdana
requested review from
a team,
ddobrigk,
dsekihat,
iarsene,
jgrosseo and
ktf
as code owners
Physicistdana
changed the title
Physicistdana
changed the title
Physicistdana
changed the title
Physicistdana
changed the title
vkucera
reviewed
Mar 29, 2026
| //------------------------------------------------ | ||
| float deltaPhi(float phi1, float phi2) | ||
| { | ||
| return std::remainder(phi1 - phi2, 2.f * static_cast<float>(M_PI)); |
Collaborator
There was a problem hiding this comment.
There is RecoDecay::constrainAngle for this.
| return std::remainder(phi1 - phi2, 2.f * static_cast<float>(M_PI)); | ||
| } | ||
|
|
||
| float deltaR(float eta1, float phi1, float eta2, float phi2) |
Collaborator
There was a problem hiding this comment.
Isn't this an existing method?
| int mpdg = mom.pdgCode(); | ||
|
|
||
| // stop at quark or gluon | ||
| if (std::abs(mpdg) == 21 || (std::abs(mpdg) >= 1 && std::abs(mpdg) <= 6)) { |
| WorkflowSpec defineDataProcessing(ConfigContext const& cfgc) | ||
| { | ||
| return WorkflowSpec{ | ||
| adaptAnalysisTask<QGTreeCreator>(cfgc, TaskName{"qg-tree-creator"})}; |
Collaborator
There was a problem hiding this comment.
Why do you need TaskName?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jet analysis code