Skip to content

[O2B-1575] Remove limited waiting time from test #2123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NarrowsProjects wants to merge 4 commits into
base: main
Choose a base branch
from
+7 −12
Open

[O2B-1575] Remove limited waiting time from test #2123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
97f69d2
doing thething
Mar 27, 2026
a055513
stealth fix a test
Mar 27, 2026
5239e22
properly set the rowcount before exporting
Mar 29, 2026
23adc99
add loading symbol whilst waiting for name
Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/public/views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,14 +102,14 @@ export const RunsPerLhcPeriodOverviewPage = ({ runs: { perLhcPeriodOverviewModel

const lhcPeriodName = remoteLhcPeriodStatistics?.match({
Success: (lhcPeriodStatistics) => lhcPeriodStatistics.lhcPeriod.name,
Other: () => '',
Other: () => spinner({ size: 1, absolute: false }),
});

return [
h('.flex-row.justify-between.items-center.g2', [
filtersPanelPopover(perLhcPeriodOverviewModel, activeColumns, { profile: 'runsPerLhcPeriod' }),
h('.pl2#runOverviewFilter', runNumbersFilter(perLhcPeriodOverviewModel.filteringModel.get('runNumbers'))),
h('h2', ['Good physics runs of ', lhcPeriodName ?? spinner({ size: 1, absolute: false })]),
h('h2', ['Good physics runs of ', lhcPeriodName]),
mcReproducibleAsNotBadToggle(
mcReproducibleAsNotBad,
() => perLhcPeriodOverviewModel.setMcReproducibleAsNotBad(!mcReproducibleAsNotBad),
Expand Down
2 changes: 1 addition & 1 deletion test/public/runs/overview.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -954,9 +954,9 @@ module.exports = () => {
await page.waitForSelector(badFilterSelector);
await page.$eval(badFilterSelector, (element) => element.click());
await page.waitForSelector('tbody tr:nth-child(2)');
await page.waitForSelector(EXPORT_RUNS_TRIGGER_SELECTOR);

///// Download
await waitForButtonToBecomeActive(page, EXPORT_RUNS_TRIGGER_SELECTOR);
await page.$eval(EXPORT_RUNS_TRIGGER_SELECTOR, (button) => button.click());
await page.waitForSelector('#export-data-modal', { timeout: 5000 });

Expand Down
13 changes: 4 additions & 9 deletions test/public/runs/runsPerLhcPeriod.overview.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,24 +201,19 @@ module.exports = () => {
// Revert changes for next test
await page.evaluate(() => {
// eslint-disable-next-line no-undef
model.runs.perLhcPeriodOverviewModel.pagination.itemsPerPage = 10;
model.runs.perLhcPeriodOverviewModel.pagination.itemsPerPage = 2;
});
Copy link
Copy Markdown
Collaborator Author

@NarrowsProjects NarrowsProjects Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could do with an explanation.

What happened here before was:

  1. The number of Items was set
  2. The next test runs
  3. The page is loaded based on the previous number of items.
  4. The number of items is changed
  5. a. Sometimes, the waitForButtonToBecomeActive resolves immediately because the change in item number doesn't result in a UI change quick enough. This will result in a failure because the button might be inactive after the active check passed.
    b. Sometimes waitForButtonToBecomeActive doesn't immediately resolve because the UI would be loading, which would temporarily disable the button. This would result in a test pass

Moving the setting as well as the row check to a previous test solves this issue.

await waitForTableLength(page, 4);
await waitForTableLength(page, 2);
});


it('should successfully export all runs per lhc Period', async () => {
await page.evaluate(() => {
// eslint-disable-next-line no-undef
model.runs.perLhcPeriodOverviewModel.pagination.itemsPerPage = 2;
});

const targetFileName = 'data.json';
await waitForButtonToBecomeActive(page, EXPORT_RUNS_TRIGGER_SELECTOR);
// First export
await pressElement(page, EXPORT_RUNS_TRIGGER_SELECTOR, true);
await page.waitForSelector('select.form-control', { timeout: 200 });
await page.waitForSelector('option[value=runNumber]', { timeout: 200 });
await page.waitForSelector('select.form-control');
await page.waitForSelector('option[value=runNumber]');
await page.select('select.form-control', 'runQuality', 'runNumber', 'definition', 'lhcPeriod');
await expectInnerText(page, '#send:enabled', 'Export');

Expand Down
Loading