[O2B-1575] Separate toolbar rendering from table rendering on runs per data pass and runs per lhc period pages#2119
Open
NarrowsProjects wants to merge 7 commits intomainfrom
Conversation
added 2 commits
March 19, 2026 13:14
…sPerLhcPeriodOverview page
…sPerDataPassOverview page
NarrowsProjects
added
frontend
javascript
…rom-table-rendering-on-RunsPerDataPass-and-RunsPerLhcPeriod-pages
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2119 +/- ##
==========================================
- Coverage 45.53% 45.35% -0.19%
==========================================
Files 1044 1044
Lines 17344 17347 +3
Branches 3145 3146 +1
==========================================
- Hits 7897 7867 -30
- Misses 9447 9480 +33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
isaachilly
reviewed
Mar 27, 2026
|
|
||
| const commonTitle = h('h2#breadcrumb-header', { style: 'white-space: nowrap;' }, 'Physics Runs'); | ||
| const runDetectorsSelectionIsEmpty = perDataPassOverviewModel.runDetectorsSelectionModel.selectedQueryString.length === 0; | ||
| const dataPass = remoteDataPass.match({ Other: () => null, Success: (data) => data }); |
Collaborator
There was a problem hiding this comment.
Could the change also be done to the RunsPerSimulationPassOverviewPage?
Maybe look at QcFlagsForDataPass and SimulationPass too and check maybe these breadcrumbs could be separated just to keep consistent.
isaachilly
reviewed
Mar 27, 2026
| h('.flex-row.justify-between.items-center.g2', [ | ||
| filtersPanelPopover(perLhcPeriodOverviewModel, activeColumns, { profile: 'runsPerLhcPeriod' }), | ||
| h('.pl2#runOverviewFilter', runNumbersFilter(perLhcPeriodOverviewModel.filteringModel.get('runNumbers'))), | ||
| h('h2', `Good, physics runs of ${lhcPeriodName}`), |
Collaborator
There was a problem hiding this comment.
This could momentarily say "Good, physics runs of null" when remoteLhcPeriodStatistics hasn't loaded yet. It would be better to show a placeholder or omit the name until loading has finished.
Collaborator
Author
There was a problem hiding this comment.
Taken care of
isaachilly
reviewed
Mar 27, 2026
| /* | ||
| * The table drawing can be done without using mergeRemoteData, but that will redraw it | ||
| * each independent update to dataPass, detectors, or qcSummary. | ||
| * While this wouldn't necessarly be noticable for users, it would would detach nodes from |
Collaborator
There was a problem hiding this comment.
Typo: necessarily, noticeable, double would
Collaborator
Author
There was a problem hiding this comment.
Taken care of
NarrowsProjects
force-pushed
the
improv/O2B-1575/Separate-toolbar-rendering-from-table-rendering-on-RunsPerDataPass-and-RunsPerLhcPeriod-pages
branch
from
a190967 to
f525a85
Compare
…rom-table-rendering-on-RunsPerDataPass-and-RunsPerLhcPeriod-pages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: