ci: pin DEPLOY_USER to circleci; add DEPLOY_NOTIFIER for Slack#3605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Number
Include an issue number if applicable.
Purpose/Implementation Notes
This pull request updates the deployment workflow to better distinguish between the identity used for Terraform deployments and the user who actually triggered the deployment. The main improvements are to environment variable handling and Slack notification messaging.
Workflow environment variable changes:
DEPLOY_USERis now always set tocirclecito ensure Terraform stacks remain consistent and do not fork for each user who pushes a deploy. This matches the legacy behavior from CircleCI. (.github/workflows/config.yml) [1] [2]DEPLOY_NOTIFIERvariable is introduced, set to the actual GitHub user who triggered the deploy, for use in notifications. (.github/workflows/config.yml) [1] [2]Notification messaging:
DEPLOY_NOTIFIERinstead ofDEPLOY_USER, so it shows who actually triggered the deployment rather than the Terraform stack identity. (.github/scripts/slackpost_deploy.sh)Methods
Types of changes
What types of changes does your code introduce?
Functional tests
N/A
Checklist
Screenshots
N/A