Publish internal changes (and footer)#389
Merged
Merged
Conversation
* Add some rough draft issue templates * Incorporate cbethell review * Get rid of `Other` labels that aren't useful
* Mechanics for CSS file and navbar add feedback URL (#303) * Adding in some style with css * Use css magic * Try making the navbar blue * Add survey link * Make font smaller * Need a comma * Change to normalizePath * normalizepath separate step references.bib * Move references.bib to component folder * Made ccs modifications, added logo file Made changes to css/navbar.html Tried to add the logo but it but it cuts out and not sure how to make it decent. * Resolve render-notebooks.R conflict * Remove testing html from file diff * uncommented mobile nav Co-authored-by: dvenprasad <dv.prasad991@gmail.com> * Update microarray and RNAseq overview figures - add context re figures - change .jpg to .png for consistency * Revert "Mechanics for CSS file and navbar add feedback URL (#303)" This reverts commit 8b81fdd. * update links to diagrams * @dvenprasad updated figure spacing * add the right updated figure * replace section of link to figures with updated commit id * incorporate @cansavvy's suggested changes Co-authored-by: Candace Savonen <cansav09@gmail.com> Co-authored-by: dvenprasad <dv.prasad991@gmail.com>
* It works! * Add feedback url * Mechanics for CSS file and navbar add feedback URL (#303) * Adding in some style with css * Use css magic * Try making the navbar blue * Add survey link * Make font smaller * Need a comma * Change to normalizePath * normalizepath separate step references.bib * Move references.bib to component folder * Made ccs modifications, added logo file Made changes to css/navbar.html Tried to add the logo but it but it cuts out and not sure how to make it decent. * Resolve render-notebooks.R conflict * Remove testing html from file diff * uncommented mobile nav Co-authored-by: dvenprasad <dv.prasad991@gmail.com> * Make the footer retrieve step consistent with others Co-authored-by: dvenprasad <dv.prasad991@gmail.com>
…t up (#313) * Updating contributing with info about staging branch * Mechanics for CSS file and navbar add feedback URL (#303) * Adding in some style with css * Use css magic * Try making the navbar blue * Add survey link * Make font smaller * Need a comma * Change to normalizePath * normalizepath separate step references.bib * Move references.bib to component folder * Made ccs modifications, added logo file Made changes to css/navbar.html Tried to add the logo but it but it cuts out and not sure how to make it decent. * Resolve render-notebooks.R conflict * Remove testing html from file diff * uncommented mobile nav Co-authored-by: dvenprasad <dv.prasad991@gmail.com> * Add more details to CONTRIBUTING about cherry picks and etc * Add bit about html preview * Incorporate Josh comment and drop log.log * Add bit about a hotfixes to staging PRs * Incorporate jashapiro feedback * Incorporate a few more bits of jashapiro feedback * Update doctoc * Make pull requests section H2 * Incorporate jashapiro suggestion to be make more specific branch names * Meh, we don't need <> * Change to use "publish" instead of "live" * Re DocToc * Add a bit more direction about PR base branches * Adjust links * Missed one link Co-authored-by: dvenprasad <dv.prasad991@gmail.com>
* Add basic templates * make it live PR template * Add html preview * Add one more "other" template * Minor edit * Polish up some things. Add "PR stage" * Minor edits * Implement cbethell review
* Get rid of headers and try a "main PR" thing. * Rearrange order * Links don't work per se * Try href strategy? * Update .github/PULL_REQUEST_TEMPLATE.md Co-authored-by: Chante Bethell <43576623+cbethell@users.noreply.github.com> Co-authored-by: Chante Bethell <43576623+cbethell@users.noreply.github.com>
* Updating contributing with info about staging branch * Mechanics for CSS file and navbar add feedback URL (#303) * Adding in some style with css * Use css magic * Try making the navbar blue * Add survey link * Make font smaller * Need a comma * Change to normalizePath * normalizepath separate step references.bib * Move references.bib to component folder * Made ccs modifications, added logo file Made changes to css/navbar.html Tried to add the logo but it but it cuts out and not sure how to make it decent. * Resolve render-notebooks.R conflict * Remove testing html from file diff * uncommented mobile nav Co-authored-by: dvenprasad <dv.prasad991@gmail.com> * Add more details to CONTRIBUTING about cherry picks and etc * Add bit about html preview * Incorporate Josh comment and drop log.log * Add bit about a hotfixes to staging PRs * Incorporate jashapiro feedback * Incorporate a few more bits of jashapiro feedback * Add the PR diagrams * Add diagrams and some words about them to CONTRIBUTING.md * Couple minor edits * Update doctoc * Make pull requests section H2 * Incorporate jashapiro suggestion to be make more specific branch names * Meh, we don't need <> * Change to use "publish" instead of "live" * Update diagrams to say "publish" * re doctoc * Some polishing of wording * Make robot emoji a png so it renders * Update commit ids * A little more words * Make headlnes more parallel * Couple little updates * A couple more polishing items * Turn⚠️ into ❌ in diagrams * Update all img commit ids * Address comments from @cbethell 's review * One little wording update Co-authored-by: dvenprasad <dv.prasad991@gmail.com>
* Make the "Other" PR template the default * Use jashapiro's wording suggestions
cansavvy
changed the title
jashapiro
reviewed
Dec 1, 2020
jashapiro
left a comment
jashapiro
left a comment
Member
There was a problem hiding this comment.
Looks good to me. The only question I have is what is 01-getting-started/getting-started.html.zip doing there? It seems to still be in the current staging branch, but why?
Contributor
Author
|
At some point when I was trying to give people previews on html stuff it snuck in there. Will remove it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Being Published
I've separated out the internal changes from the original #383 (plus a PR that has basic changes to the footer since I wasn't sure where else that should fit).
I got this branch together by checking out master, and cherry picking all these commits.
List of Commits/PR's Included
Link to html Preview
For reviewing purposes, you can take a browse through htmlpreview: http://htmlpreview.github.io/?https://github.com/AlexsLemonade/refinebio-examples/gh-pages-stages/01-getting-started/getting-started.html