fix(mpris): fall back to next non-ignored player and prefer playing players#4846
Open
BlueManCZ wants to merge 3 commits intoAlexays:masterfrom
Open
fix(mpris): fall back to next non-ignored player and prefer playing players#4846BlueManCZ wants to merge 3 commits intoAlexays:masterfrom
BlueManCZ wants to merge 3 commits intoAlexays:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
playerctld, the MPRIS module had several issues with player selection:ignored-players,getPlayerInfo()returnedstd::nulloptwith no fallback, hiding the widgetentirely even when other valid players were available.
take over the widget even if another player (e.g. Tidal) was actively playing, because playerctld
orders by most recently active rather than playback state.
onPlayerStophid the widget before triggering theupdate, causing a visible flash before
update()re-showed it with the correct player.Changes
a playing player over a paused/stopped one
PlayerctlPlayerconnection for correct metadataevent_box_.set_visible(false)fromonPlayerStop—update()alreadyhandles visibility
Test plan
ignored-playerswith a browser (e.g.["firefox"]), have another player paused— widget should show the paused player with correct metadata when browser plays media
Fixes: #1954, fixes: #3879, fixes: #4610