feat: add {tooltip} in format replacements in custom module#4836
Open
Cprakhar wants to merge 1 commit intoAlexays:masterfrom
Open
feat: add {tooltip} in format replacements in custom module#4836Cprakhar wants to merge 1 commit intoAlexays:masterfrom
{tooltip} in format replacements in custom module#4836Cprakhar wants to merge 1 commit intoAlexays:masterfrom
Conversation
Contributor
Author
|
Need to update Custom module wiki, if PR merged. |
{tooltip} in format strings in custom modules{tooltip} in format strings in custom modules
d5a3c9d to
d088b3f
Compare
{tooltip} in format strings in custom modules{tooltip} in format replacements in custom module
d088b3f to
f96fb53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a key issue in custom module.
tooltipcannot be passed in"tooltip": "{tooltip} some random text"when return-type isjson, as{tooltip}is not added in format replacements.Before:
~/.config/waybar/scripts/pacman-updates.pycustom-pacman.jsoncVerification
Tested locally, working fine.
Closes #4786