Allow disabling rate limiting for users via exceptions list from core#617
Allow disabling rate limiting for users via exceptions list from core#617bitterpanda63 wants to merge 1 commit intomainfrom
Conversation
| received_any_stats=res.get("receivedAnyStats", True), | ||
| ) | ||
|
|
||
| # Handle excluded user IDs from rate limiting |
There was a problem hiding this comment.
Inline comment only restates the code's action; prefer explaining why excludedUserIdsFromRateLimiting matters or remove the comment.
| # Handle excluded user IDs from rate limiting | |
| # Apply server-configured exemptions to allow specific users to bypass rate limiting |
Details
✨ AI Reasoning
The new inline comment merely restates the purpose of the following code block (pulling excluded user IDs from the response). It doesn't provide context about expected shape, backward compatibility, or why this field matters, so it is a low-value 'what' comment.
Reply @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info
| def update_excluded_user_ids_from_rate_limiting(self, user_ids): | ||
| """Replaces the set of user IDs excluded from rate limiting""" |
There was a problem hiding this comment.
Docstring repeats the method name/behavior without explaining why or expected semantics; replace with rationale (e.g., why exclusions exist or expected ID format) or remove the docstring.
| def update_excluded_user_ids_from_rate_limiting(self, user_ids): | |
| """Replaces the set of user IDs excluded from rate limiting""" | |
| def update_excluded_user_ids_from_rate_limiting(self, user_ids): | |
| """Updates the exclusion list to control which users bypass rate limiting checks""" |
Details
✨ AI Reasoning
The new docstring for the method simply restates what the method name and implementation already make obvious (it replaces the set of excluded user IDs). It provides no 'why' or additional context about expected formats or semantics, so it is a "what" comment that adds maintenance burden.
Reply @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info
Summary by Aikido
⚡ Enhancements
More info