Skip to content

Allow disabling rate limiting for users via exceptions list from core#617

Open
bitterpanda63 wants to merge 1 commit intomainfrom
add-ratelimit-exceptions-python
Open

Allow disabling rate limiting for users via exceptions list from core#617
bitterpanda63 wants to merge 1 commit intomainfrom
add-ratelimit-exceptions-python

Conversation

@bitterpanda63
Copy link
Copy Markdown
Member

@bitterpanda63 bitterpanda63 commented Apr 10, 2026

Summary by Aikido

Security Issues: 0 🔍 Quality Issues: 2 Resolved Issues: 0

⚡ Enhancements

  • Allowed disabling rate limiting for specified users via core exceptions

More info

@bitterpanda63 bitterpanda63 changed the title Allow disabling rate limit for users via exceptions list from core Allow disabling rate limiting for users via exceptions list from core Apr 10, 2026
received_any_stats=res.get("receivedAnyStats", True),
)

# Handle excluded user IDs from rate limiting
Copy link
Copy Markdown

@aikido-pr-checks aikido-pr-checks bot Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline comment only restates the code's action; prefer explaining why excludedUserIdsFromRateLimiting matters or remove the comment.

Suggested change
# Handle excluded user IDs from rate limiting
# Apply server-configured exemptions to allow specific users to bypass rate limiting
Details

✨ AI Reasoning
​The new inline comment merely restates the purpose of the following code block (pulling excluded user IDs from the response). It doesn't provide context about expected shape, backward compatibility, or why this field matters, so it is a low-value 'what' comment.

Reply @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info

Comment on lines +79 to +80
def update_excluded_user_ids_from_rate_limiting(self, user_ids):
"""Replaces the set of user IDs excluded from rate limiting"""
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstring repeats the method name/behavior without explaining why or expected semantics; replace with rationale (e.g., why exclusions exist or expected ID format) or remove the docstring.

Suggested change
def update_excluded_user_ids_from_rate_limiting(self, user_ids):
"""Replaces the set of user IDs excluded from rate limiting"""
def update_excluded_user_ids_from_rate_limiting(self, user_ids):
"""Updates the exclusion list to control which users bypass rate limiting checks"""
Details

✨ AI Reasoning
​The new docstring for the method simply restates what the method name and implementation already make obvious (it replaces the set of excluded user IDs). It provides no 'why' or additional context about expected formats or semantics, so it is a "what" comment that adds maintenance burden.

Reply @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant