Fix password validation (Fixes #2737)#4101
Open
Excali556 wants to merge 5 commits intoAgenta-AI:mainfrom
Open
Conversation
… calling tracing/instrumentation methods before initialization failed silently. This adds a clear warning to guide users to call ag.init() first.
|
@Excali556 is attempting to deploy a commit to the agenta projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, password validation relied on SuperTokens' default rules, which led to inconsistent behavior (e.g., requiring alphabet characters). This was not explicitly defined in the codebase and caused confusion during login and signup.
This change explicitly defines a custom password validator in the SuperTokens configuration, enforcing a minimum length of 8 characters. This ensures consistent and predictable behavior.
Testing
Verified locally
Ran
python -m compileall .to ensure no syntax errorsManually tested signup and login flows:
Added or updated tests
N/A
QA follow-up
N/A
Demo
N/A
Checklist