feat: Add ISOBUS bus control function enumeration and TC conflict det…#59
Merged
Conversation
…ection - Add enumerate_bus_control_functions() to list all CFs on the bus with NAME details (address, manufacturer code, function code, industry group, identity number) - Log bus CFs before and after creating internal TC/TECU control functions - Add check_tc_address_conflict() to detect and warn when another TC claims preferred address - Periodic WARN message every 30 seconds when TC address conflict is present - Use numeric codes only for cleaner, more maintainable output format - Tag internal control functions with [INTERNAL] marker in enumeration output This improves debugging visibility into ISOBUS network state and helps diagnose address claim conflicts when multiple Task Controllers are present on the bus.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds runtime diagnostics to improve visibility into ISOBUS control functions (CFs) present on the bus and to detect/report Task Controller (TC) preferred-address conflicts, helping troubleshoot multi-TC setups and address-claim issues.
Changes:
- Added
enumerate_bus_control_functions()to print bus CFs (with NAME fields and[INTERNAL]tagging) before/after internal CF creation. - Added
check_tc_address_conflict()and wired it into the main update loop to periodically warn when another TC holds the preferred TC address. - Added additional numeric-only logging details for easier debugging output parsing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Build result: |
Pat-I
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ection
This improves debugging visibility into ISOBUS network state and helps diagnose address claim conflicts when multiple Task Controllers are present on the bus.