Skip to content

🎨 Palette: Enhance keyboard accessibility for interactive elements in Signup #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AntonioCardenas wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🎨 Palette: Enhance keyboard accessibility for interactive elements in Signup #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 33 additions & 6 deletions src/components/Signup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,8 +725,17 @@ const Signup = () => {
<div className="flex avatar w-24 bg-red-500 mx-auto">
<img
src={selectedImage !== '' ? selectedImage : User}
className="rounded-xl"
className="rounded-xl cursor-pointer focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-blue-500"
onClick={handleClick}
onKeyDown={(e) => {
if (e.key === 'Enter' || e.key === ' ') {
e.preventDefault();
handleClick(e);
}
}}
role="button"
tabIndex={0}
aria-label={(t('upload-image') as string) || 'Upload image'}
/>
<Form.Control
type="file"
Expand Down Expand Up @@ -926,18 +935,36 @@ const Signup = () => {
{!state.accountCreated ? (
<div className="">
<div className="bg-base-100 pt-4 rounded-t-xl m-12 lg:mx-64">
<div className="flex tabs justify-center">
<div className="flex tabs justify-center" role="tablist">
<a
className={`${activeTab == 'farmer' && `tab btn-wide tab-lg tab-lifted tab-active`} tab btn-wide tab-lg `}
id="signup-tabs"
className={`${activeTab == 'farmer' && `tab btn-wide tab-lg tab-lifted tab-active`} tab btn-wide tab-lg focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-blue-500`}
id="signup-tabs-farmer"
onClick={() => setActiveTab('farmer')}
onKeyDown={(e) => {
if (e.key === 'Enter' || e.key === ' ') {
e.preventDefault();
setActiveTab('farmer');
}
}}
role="tab"
aria-selected={activeTab === 'farmer'}
tabIndex={0}
>
<>{t('farmer')}</>
</a>
<a
className={`${activeTab == 'cooperative' && `tab btn-wide tab-lg tab-lifted tab-active`} tab btn-wide tab-lg `}
id="signup-tabs"
className={`${activeTab == 'cooperative' && `tab btn-wide tab-lg tab-lifted tab-active`} tab btn-wide tab-lg focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-blue-500`}
id="signup-tabs-company"
onClick={() => setActiveTab('cooperative')}
onKeyDown={(e) => {
if (e.key === 'Enter' || e.key === ' ') {
e.preventDefault();
setActiveTab('cooperative');
}
}}
role="tab"
aria-selected={activeTab === 'cooperative'}
tabIndex={0}
>
<>{t('company')}</>
</a>
Expand Down