Potential fix for code scanning alert no. 3: Polynomial regular expression used on uncontrolled data - #291
Open
Exohayvan wants to merge 1 commit into
Open
Potential fix for code scanning alert no. 3: Polynomial regular expression used on uncontrolled data#291Exohayvan wants to merge 1 commit into
Exohayvan wants to merge 1 commit into
Conversation
…ssion used on uncontrolled data
Exohayvan
marked this pull request as ready for review
July 23, 2026 02:07
Exohayvan
added
type:bug
Exohayvan
added
status:ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/AetherMesh-AI/aethermesh-core/security/code-scanning/3
The best fix is to replace the regular-expression scheme check with bounded, linear string parsing before accepting an artifact or log reference.
Concretely, in
src/aethermesh_core/job_result_schema.py,_artifact_reference_listnow delegates URI-scheme detection to_starts_with_uri_scheme. The helper splits once at the first colon and validates the same ASCII scheme grammar without regex backtracking. This preserves the existing rejection behavior for URI-like and Windows drive references while ensuring long user-controlled strings are handled in linear time.A regression test validates a 100,000-character reference while making any fallback to
re.matchfail explicitly. No API or schema changes are required.Suggested fixes powered by Copilot Autofix. Review carefully before merging.