Potential fix for code scanning alert no. 5: Clear-text storage of sensitive information - #290
Open
Exohayvan wants to merge 1 commit into
Open
Potential fix for code scanning alert no. 5: Clear-text storage of sensitive information#290Exohayvan wants to merge 1 commit into
Exohayvan wants to merge 1 commit into
Conversation
…nsitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Exohayvan
marked this pull request as ready for review
July 23, 2026 02:07
Exohayvan
added
type:bug
Exohayvan
added
status:ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/AetherMesh-AI/aethermesh-core/security/code-scanning/5
The best fix is to guarantee sensitive free-text fields are redacted before serialization, not only based on key names but also for known high-risk textual fields that can embed credentials (like
error_summary). This keeps existing functionality (append JSONL audit records) while preventing secret literals from being stored.In
src/aethermesh_core/local_audit_event.py, update_sanitize_audit_valueso that when a value is a string, it applies secret-text redaction first and then path sanitization consistently; and ensure known sensitive-content keys are fully redacted by key-name logic already present. This strengthens the sanitization boundary immediately before persistence without changing caller behavior or file format. No test file changes are required if existing tests already validate redaction behavior.Suggested fixes powered by Copilot Autofix. Review carefully before merging.