feat: add per-owner spending limits and approval-count property test#213
Merged
thegreatfeez merged 1 commit intoJun 27, 2026
Conversation
|
@Omoboi-dev is attempting to deploy a commit to the thegreatfeez's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Omoboi-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#41 Per-owner spending limits per token
Adds an optional per-owner cap on the amount an owner can propose for a given token.
SetSpendingLimit(owner, token, limit)variant onProposalKind. A limit of 0 blocks that token entirely; an absent limit means unlimited.create_spending_limit_proposalcreates a governance proposal to set a limit. It runs the same owner, frozen, description and deadline checks as the other create functions. Note: the name was shortened from the suggestedcreate_set_spending_limit_proposalbecause Soroban caps contract function names at 32 characters.create_proposalnow rejects a transfer proposal with the newSpendingLimitExceedederror (code 28) when the proposer has a configured limit and the amount exceeds it.get_spending_limit(owner, token)read function returns the stored limit orNonewhen unlimited.#55 Property test: approval count never exceeds owner count
proptestas a dev dependency.approval_count_never_exceeds_owner_counttest: for a random owner count (1 to 20) and threshold, it builds a fresh env, initializes the multisig, creates a proposal, has every owner approve, and asserts approvals equals the owner count and that a duplicate approval returnsAlreadyApproved.Tests
cargo test -p accordpasses 70/0, including the two new #41 lifecycle tests and the #55 property test.Closes #41
Closes #55