11222 Throw on Duplicate Cultivars#11223
Open
par456 wants to merge 3 commits into
Open
Conversation
Collaborator
Author
|
@HamishBrownPFR Can you have a quick look and advise on what should happen to resolve this conflict? |
Collaborator
Author
|
A note later for @hut104 as well, in Lucerne we have "southern_special" defined as an alias for both FD5 and FD7. FD5 is a cultivar with no changes, while FD7 has cultivar changes. In the LucerneValidation, southern_special was used only in the Griffith experiment, so its just a matter of if that was supposed to be using FD5 (Lucerne with no cultivar changes) or FD7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #11222
Add in check to throw when a cultivar is defined multiple times. Which it was previously possible to 'override' a cultivar by defining it again with the same name in the simulation, this will not throw and require users to either use the Replacements folder to do the override, or give their cultivar a different name so it isn't confused with the Release cultivar.
This is also important to prevent name conflicts in the resource system and the wrong version of a cultivar getting run or referenced accidently.
Already found a duplicate placeholder Rockstar defined in the FAR validation that has been removed, however other parts of the validation might need to be fixed to solve this correctly.