fix: strict Stellar key validation in ConnectWalletDto + maintainer runbook#506
Merged
Eniola3321 merged 1 commit intoJun 26, 2026
Conversation
…iner runbook Issue ANYTECHS#446: Add publicKey field (56-char G-prefix Base32), signature, and signedMessage fields to CreateWalletConnectionDto with class-validator decorators. Issue ANYTECHS#445: Create docs/runbook.md covering deployment steps, environment checklist, monitoring endpoints/metrics, BullMQ queue recovery procedures, and incident response playbooks for P1–P5 scenarios. Closes ANYTECHS#446 Closes ANYTECHS#445
|
@mogbonjubolaolasunkanmi-art Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves two open issues in a single commit.
Closes #446 —
[Wallet] Create ConnectWalletDtoEnhanced
CreateWalletConnectionDtoinsrc/wallets/dto/connect-wallet.dto.tswith strict Stellar public key validation and proof-of-ownership fields:publicKey—@Length(56, 56)+@Matches(/^G[A-Z2-7]{55}$/): enforces G-prefix, Base32 alphabet, exact 56-character length.signature— required string; Base64-encoded wallet signature of the nonce.signedMessage— required string; the plaintext nonce that was signed (proves key ownership).@ApiPropertydescriptions for Swagger / frontend integration.Closes #445 —
Create Maintainer Runbook DocumentationCreated
docs/runbook.mdcovering:/health,/metricsendpoint, key Prometheus metrics, recommended alert thresholds.Testing
nft-mint.service.spec.tsandearnings.service.tsare not introduced by this PR — confirmed by checking the base branch).class-validatordecorators are consistent with patterns used throughout the codebase (e.g.auth/dto/signup.dto.ts,nft/dto/mint-clip.dto.ts).