Repository navigation
feat: ZK-065 – full ZK validation CI pipeline with artifact drift detection - #460
Open
rushikeshgarad2024-dev wants to merge 1 commit into
Open
rushikeshgarad2024-dev wants to merge 1 commit into
rushikeshgarad2024-dev wants to merge 1 commit into
Conversation
…ection - Add .github/workflows/zk-full-validation.yml with four dedicated jobs: 1. zk-nargo-tests: installs noirup + runs nargo test for each circuit 2. zk-sdk-tests: installs Node 20, runs npm test in sdk/, smoke tests 3. zk-artifact-drift: recompiles circuits, diffs artifacts/zk/ (dirty = fail) 4. zk-manifest-validation: validates manifest.json schema + required fields - Add scripts/zk-full-validation-local.sh for local reproduction (mirrors all four CI checks with --nargo/--sdk/--drift/--manifest flags) - Workflow scoped to ZK paths only (circuits/, sdk/, artifacts/zk/, scripts/) - No frontend or contract-deployment dependencies Wave Issue Key: ZK-065
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the ZK-065 acceptance criteria by introducing a CI workflow that runs the full ZK validation stack from a clean checkout, with no frontend or contract-deployment dependencies.
Wave Issue Key: ZK-065
What was implemented
.github/workflows/zk-full-validation.ymlA four-job workflow that triggers on
pushtomainand on any PR touchingcircuits/,sdk/,artifacts/zk/,scripts/, or the workflow file itself.zk-nargo-testsnoirup, validatesmanifest.jsonexists, runsnargo testforcommitment,merkle, andwithdrawcircuitszk-sdk-testsnpm ciinsdk/, runs full Jest suite (npm test), runsscripts/zk/zk-proof-smoke.mjszk-artifact-driftnargo compile, copies outputs back toartifacts/zk/, runsgit diff; a non-empty diff fails the buildzk-manifest-validationmanifest.jsonschema (version, backend, circuit entries with sha256 + path), assertscommitment_vectors.jsonis presentA final
zk-validation-summarygate job aggregates results and prints a human-readable status table.scripts/zk-full-validation-local.shShell script for local reproduction with flags mirroring each CI job:
Acceptance criteria checklist
scripts/zk-full-validation-local.sh)