fix(sdk): include version in pnpm cp source path#491
Open
erikreinert wants to merge 5 commits into
Open
Conversation
The cp step in the pnpm artifact's stepScript referenced
./source/pnpm/pnpm-{target}, but the agent materializes the
downloaded binary using the URL basename — which is
pnpm-{version}-{target} after the CDN migration in 52de584.
Without this fix, every pnpm build fails at the cp step on
every target. Apply the same one-line fix across Go, Rust,
and TypeScript SDKs.
CI on macos-latest (macos-arm64) failed with the same class of error
that motivated DKT-2: the S3 archive at the lockfile-pinned digest
contains the old filename pnpm-{target} (no version) because it was
uploaded before the CDN URL convention changed. Since the registry
short-circuits on digest hit and S3 push is idempotent, the cached
archive cannot self-heal.
Flip the predicate so only macos-x64 uses the new
pnpm-{version}-{target} cp pattern; macos-arm64 joins linux-arm64
and linux-x64 on the old pnpm-{target} pattern that matches the
poisoned cache.
The Go SDK's strings import becomes unused after the predicate change
and is removed.
Echo the target string and expected cp source path, then ls -la the source directory before cp runs. Gives CI logs ground-truth visibility into what's on disk per platform so any future cache or path divergence shows up immediately instead of requiring code-traced inference. Debug applied symmetrically across Go, Rust, and TypeScript SDKs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cpstep in thepnpmartifact'sstepScriptreferenced./source/pnpm/pnpm-{target}, but the Vorpal agent materializes the downloaded binary using the URL basename — which ispnpm-{version}-{target}after the CDN migration in52de584. Without this fix, everypnpmbuild fails at thecpstep on every target../source/{name}/pnpm-{version}-{target}) so thecpsource path matches what the agent actually writes to disk.cli/src/command/start/agent.rs(Mach-O for darwin, ELF for linux), which writes the URL basename verbatim with no extension stripping or archive extraction.