Refactor - Script stores bytes, not strings#50
Open
DaMatrix wants to merge 3 commits intoAIBlockOfficial:developfrom
Open
Refactor - Script stores bytes, not strings#50DaMatrix wants to merge 3 commits intoAIBlockOfficial:developfrom
DaMatrix wants to merge 3 commits intoAIBlockOfficial:developfrom
Conversation
BHouwens
reviewed
Aug 4, 2024
Contributor
BHouwens
left a comment
There was a problem hiding this comment.
This one will require testing against existing chain data to ensure you've got all the edge cases in handling legacy stacks. Otherwise, looks all good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR depends on #42 (
placeholders).Our scripts can contain "byte array" constants, however they are actually represented as UTF-8 strings which in practice always contain hexadecimal data. This is not only inefficient, but also means that many of the stack operations behave in unexpected ways (e.g. the indices passed to
OP_SUBSTRare effectively in units of half-bytes rather than bytes). This PR changes them into actual byte vectors, although for now they are still temporarily converted to hex strings in order to emulate the original behavior when performing cryptographic operations on the stack. In the future (preferably before all of these refactor PRs get merged), it would be ideal if this hex string translation could be eliminated, as it will likely be a major source of bugs for other developers attempting to work with our system.Changelog
StackEntry::Bytesto contain aVec<u8>instead of aStringStackEntry::Bytesfrom hex strings to byte arrays, as necessaryType of Change
Please mark the appropriate option by putting an "x" inside the brackets:
Checklist
Put an "x" in the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!
Screenshots (if applicable)
If the changes affect the UI or have visual effects, please provide screenshots or GIFs showcasing the changes.
Additional Context (if applicable)
Add any additional context or information about the changes that may be helpful in understanding the pull request.
Related Issues (if applicable)
If this pull request is related to any existing issues, please list them here.
Requested Reviewers
Mention any specific individuals or teams you would like to request a review from.